riscv: cpufeature: use bitmap_equal() instead of memcmp()

clementleger · gregkh · commit a3c5eb88f0ba · 2025-03-07T18:25:45.000+01:00
commit c6ec1e1 upstream. Comparison of bitmaps should be done using bitmap_equal(), not memcmp(), use the former one to compare isa bitmaps. Signed-off-by: Clément Léger <cleger@rivosinc.com> Fixes: 625034a ("riscv: add ISA extensions validation callback") Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250210155615.1545738-1-cleger@rivosinc.com Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
@@ -454,7 +454,7 @@ static void __init riscv_resolve_isa(unsigned long *source_isa,
 			if (bit < RISCV_ISA_EXT_BASE)
 				*this_hwcap |= isa2hwcap[bit];
 		}
-	} while (loop && memcmp(prev_resolved_isa, resolved_isa, sizeof(prev_resolved_isa)));
+	} while (loop && !bitmap_equal(prev_resolved_isa, resolved_isa, RISCV_ISA_EXT_MAX));
 }
 
 static void __init match_isa_ext(const char *name, const char *name_end, unsigned long *bitmap)

Original file line number	Diff line number	Diff line change
`@@ -454,7 +454,7 @@ static void __init riscv_resolve_isa(unsigned long *source_isa,`
`454`	`454`	`if (bit < RISCV_ISA_EXT_BASE)`
`455`	`455`	`*this_hwcap \|= isa2hwcap[bit];`
`456`	`456`	`}`
`457`		`- } while (loop && memcmp(prev_resolved_isa, resolved_isa, sizeof(prev_resolved_isa)));`
	`457`	`+ } while (loop && !bitmap_equal(prev_resolved_isa, resolved_isa, RISCV_ISA_EXT_MAX));`
`458`	`458`	`}`
`459`	`459`
`460`	`460`	`static void __init match_isa_ext(const char name, const char name_end, unsigned long *bitmap)`