Skip to content

Commit a1fd0b9

Browse files
vitalyvbIngo Molnar
authored andcommitted
sched/fair: Allow disabling sched_balance_newidle with sched_relax_domain_level
Change relax_domain_level checks so that it would be possible to include or exclude all domains from newidle balancing. This matches the behavior described in the documentation: -1 no request. use system default or follow request of others. 0 no search. 1 search siblings (hyperthreads in a core). "2" enables levels 0 and 1, level_max excludes the last (level_max) level, and level_max+1 includes all levels. Fixes: 1d3504f ("sched, cpuset: customize sched domains, core") Signed-off-by: Vitalii Bursov <vitaly@bursov.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> Reviewed-by: Valentin Schneider <vschneid@redhat.com> Link: https://lore.kernel.org/r/bd6de28e80073c79466ec6401cdeae78f0d4423d.1714488502.git.vitaly@bursov.com
1 parent e5bc44e commit a1fd0b9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

kernel/cgroup/cpuset.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2948,7 +2948,7 @@ bool current_cpuset_is_being_rebound(void)
29482948
static int update_relax_domain_level(struct cpuset *cs, s64 val)
29492949
{
29502950
#ifdef CONFIG_SMP
2951-
if (val < -1 || val >= sched_domain_level_max)
2951+
if (val < -1 || val > sched_domain_level_max + 1)
29522952
return -EINVAL;
29532953
#endif
29542954

kernel/sched/topology.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1475,7 +1475,7 @@ static void set_domain_attribute(struct sched_domain *sd,
14751475
} else
14761476
request = attr->relax_domain_level;
14771477

1478-
if (sd->level > request) {
1478+
if (sd->level >= request) {
14791479
/* Turn off idle balance on this domain: */
14801480
sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
14811481
}

0 commit comments

Comments
 (0)