Skip to content

Commit 9e81e32

Browse files
arndbKAGA-KOKO
authored andcommitted
irqchip/armada-370-xp: Suppress unused-function warning
armada_370_xp_msi_reenable_percpu() is only defined when CONFIG_PCI_MSI is enabled, and only called when SMP is enabled. Without CONFIG_SMP, there are no callers, which results in a build time warning instead: drivers/irqchip/irq-armada-370-xp.c:319:13: error: 'armada_370_xp_msi_reenable_percpu' defined but not used [-Werror=unused-function] 319 | static void armada_370_xp_msi_reenable_percpu(void) {} | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Mark the function as __maybe_unused to avoid adding more complexity to the #ifdefs. Fixes: 8ca61cd ("irqchip/armada-370-xp: Enable MSI affinity configuration") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://lore.kernel.org/r/20240322125838.901649-1-arnd@kernel.org
1 parent c2ddeb2 commit 9e81e32

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/irqchip/irq-armada-370-xp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ static int armada_370_xp_msi_init(struct device_node *node,
316316
return 0;
317317
}
318318
#else
319-
static void armada_370_xp_msi_reenable_percpu(void) {}
319+
static __maybe_unused void armada_370_xp_msi_reenable_percpu(void) {}
320320

321321
static inline int armada_370_xp_msi_init(struct device_node *node,
322322
phys_addr_t main_int_phys_base)

0 commit comments

Comments
 (0)