Skip to content

Commit 9dbbcd6

Browse files
committed
Merge tag 'thermal-v6.10-rc1-2' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux
Merge thermal driver fixes for 6.10-rc1 from Daniel Lezcano: "- Check for a NULL pointer before using it in the probe routine of the Mediatek LVTS driver (Julien Panis) - Remove the num_lvts_sensor and cal_offset fields of the lvts_ctrl_data as they are not used. These are not functional fixes but slight memory usage fix of the Mediatek LVTS driver (Julien Panis) - Fix wrong lvts_ctrl index leading to a NULL pointer dereference in the Mediatek LVTS driver (Julien Panis)" * tag 'thermal-v6.10-rc1-2' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux: thermal/drivers/mediatek/lvts_thermal: Fix wrong lvts_ctrl index thermal/drivers/mediatek/lvts_thermal: Remove unused members from struct lvts_ctrl_data thermal/drivers/mediatek/lvts_thermal: Check NULL ptr on lvts_data
2 parents f952b6c + b66c079 commit 9dbbcd6

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

drivers/thermal/mediatek/lvts_thermal.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,6 @@ struct lvts_sensor_data {
105105

106106
struct lvts_ctrl_data {
107107
struct lvts_sensor_data lvts_sensor[LVTS_SENSOR_MAX];
108-
int cal_offset[LVTS_SENSOR_MAX];
109-
int num_lvts_sensor;
110108
u8 valid_sensor_mask;
111109
int offset;
112110
int mode;
@@ -118,9 +116,9 @@ struct lvts_ctrl_data {
118116
((s2) ? BIT(2) : 0) | \
119117
((s3) ? BIT(3) : 0))
120118

121-
#define lvts_for_each_valid_sensor(i, lvts_ctrl_data) \
119+
#define lvts_for_each_valid_sensor(i, lvts_ctrl) \
122120
for ((i) = 0; (i) < LVTS_SENSOR_MAX; (i)++) \
123-
if (!((lvts_ctrl_data)->valid_sensor_mask & BIT(i))) \
121+
if (!((lvts_ctrl)->valid_sensor_mask & BIT(i))) \
124122
continue; \
125123
else
126124

@@ -147,6 +145,7 @@ struct lvts_ctrl {
147145
const struct lvts_data *lvts_data;
148146
u32 calibration[LVTS_SENSOR_MAX];
149147
u32 hw_tshut_raw_temp;
148+
u8 valid_sensor_mask;
150149
int mode;
151150
void __iomem *base;
152151
int low_thresh;
@@ -358,7 +357,7 @@ static bool lvts_should_update_thresh(struct lvts_ctrl *lvts_ctrl, int high)
358357
if (high > lvts_ctrl->high_thresh)
359358
return true;
360359

361-
lvts_for_each_valid_sensor(i, lvts_ctrl->lvts_data->lvts_ctrl)
360+
lvts_for_each_valid_sensor(i, lvts_ctrl)
362361
if (lvts_ctrl->sensors[i].high_thresh == lvts_ctrl->high_thresh
363362
&& lvts_ctrl->sensors[i].low_thresh == lvts_ctrl->low_thresh)
364363
return false;
@@ -619,6 +618,8 @@ static int lvts_sensor_init(struct device *dev, struct lvts_ctrl *lvts_ctrl,
619618
lvts_sensor[i].high_thresh = INT_MIN;
620619
};
621620

621+
lvts_ctrl->valid_sensor_mask = lvts_ctrl_data->valid_sensor_mask;
622+
622623
return 0;
623624
}
624625

@@ -1114,7 +1115,7 @@ static int lvts_ctrl_start(struct device *dev, struct lvts_ctrl *lvts_ctrl)
11141115
u32 *sensor_bitmap = lvts_ctrl->mode == LVTS_MSR_IMMEDIATE_MODE ?
11151116
sensor_imm_bitmap : sensor_filt_bitmap;
11161117

1117-
lvts_for_each_valid_sensor(i, lvts_ctrl->lvts_data->lvts_ctrl) {
1118+
lvts_for_each_valid_sensor(i, lvts_ctrl) {
11181119

11191120
int dt_id = lvts_sensors[i].dt_id;
11201121

@@ -1271,6 +1272,8 @@ static int lvts_probe(struct platform_device *pdev)
12711272
return -ENOMEM;
12721273

12731274
lvts_data = of_device_get_match_data(dev);
1275+
if (!lvts_data)
1276+
return -ENODEV;
12741277

12751278
lvts_td->clk = devm_clk_get_enabled(dev, NULL);
12761279
if (IS_ERR(lvts_td->clk))

0 commit comments

Comments
 (0)