Skip to content

Commit 9133e6e

Browse files
ericchancfpalmer-dabbelt
authored andcommitted
riscv/barrier: Add missing space after ','
The past form of RISCV_FENCE would cause checkpatch.pl to issue error messages, the example is as follows: ERROR: space required after that ',' (ctx:VxV) 26: FILE: arch/riscv/include/asm/barrier.h:27: +#define __smp_mb() RISCV_FENCE(rw,rw) ^ fix the remaining of RISCV_FENCE. Signed-off-by: Eric Chan <ericchancf@google.com> Reviewed-by: Andrea Parri <parri.andrea@gmail.com> Reviewed-by: Samuel Holland <samuel.holland@sifive.com> Tested-by: Samuel Holland <samuel.holland@sifive.com> Link: https://lore.kernel.org/r/20240217131328.3669364-1-ericchancf@google.com Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
1 parent c85688e commit 9133e6e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

arch/riscv/include/asm/barrier.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,22 @@
2424
#define __wmb() RISCV_FENCE(ow, ow)
2525

2626
/* These barriers do not need to enforce ordering on devices, just memory. */
27-
#define __smp_mb() RISCV_FENCE(rw,rw)
28-
#define __smp_rmb() RISCV_FENCE(r,r)
29-
#define __smp_wmb() RISCV_FENCE(w,w)
27+
#define __smp_mb() RISCV_FENCE(rw, rw)
28+
#define __smp_rmb() RISCV_FENCE(r, r)
29+
#define __smp_wmb() RISCV_FENCE(w, w)
3030

3131
#define __smp_store_release(p, v) \
3232
do { \
3333
compiletime_assert_atomic_type(*p); \
34-
RISCV_FENCE(rw,w); \
34+
RISCV_FENCE(rw, w); \
3535
WRITE_ONCE(*p, v); \
3636
} while (0)
3737

3838
#define __smp_load_acquire(p) \
3939
({ \
4040
typeof(*p) ___p1 = READ_ONCE(*p); \
4141
compiletime_assert_atomic_type(*p); \
42-
RISCV_FENCE(r,rw); \
42+
RISCV_FENCE(r, rw); \
4343
___p1; \
4444
})
4545

@@ -68,7 +68,7 @@ do { \
6868
* instances the scheduler pairs this with an mb(), so nothing is necessary on
6969
* the new hart.
7070
*/
71-
#define smp_mb__after_spinlock() RISCV_FENCE(iorw,iorw)
71+
#define smp_mb__after_spinlock() RISCV_FENCE(iorw, iorw)
7272

7373
#include <asm-generic/barrier.h>
7474

0 commit comments

Comments
 (0)