Skip to content

Commit 89ea21d

Browse files
timschumiardbiesheuvel
authored andcommitted
efivarfs: Remove unused internal struct members
The structure was moved to the efivarfs internals in commit 2d82e62 ("efi: vars: Move efivar caching layer into efivarfs") after previously being used as the data ABI for efivars until its removal in commit 0f5b2c6 ("efi: vars: Remove deprecated 'efivars' sysfs interface"). As efivarfs only uses the structure for the variable name caching layer, the data-related members were never in use. Remove them to avoid implying that efivarfs is bound by the same restrictions that efivars once had. While at it, remove the packed attribute, since we no longer have to guarantee a stable layout. Signed-off-by: Tim Schumacher <timschumi@gmx.de> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
1 parent 5b62518 commit 89ea21d

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

fs/efivarfs/internal.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,8 @@ struct efivarfs_fs_info {
2424
struct efi_variable {
2525
efi_char16_t VariableName[EFI_VAR_NAME_LEN/sizeof(efi_char16_t)];
2626
efi_guid_t VendorGuid;
27-
unsigned long DataSize;
28-
__u8 Data[1024];
29-
efi_status_t Status;
3027
__u32 Attributes;
31-
} __attribute__((packed));
28+
};
3229

3330
struct efivar_entry {
3431
struct efi_variable var;

0 commit comments

Comments
 (0)