Skip to content

Commit 873a400

Browse files
YWHyukhtejun
authored andcommitted
workqueue: Fix type of cpu in trace event
The trace event "workqueue_queue_work" use unsigned int type for req_cpu, cpu. This casue confusing cpu number like below log. $ cat /sys/kernel/debug/tracing/trace cat-317 [001] ...: workqueue_queue_work: ... req_cpu=8192 cpu=4294967295 So, change unsigned type to signed type in the trace event. After applying this patch, cpu number will be printed as -1 instead of 4294967295 as folllows. $ cat /sys/kernel/debug/tracing/trace cat-1338 [002] ...: workqueue_queue_work: ... req_cpu=8192 cpu=-1 Cc: Baik Song An <bsahn@etri.re.kr> Cc: Hong Yeon Kim <kimhy@etri.re.kr> Cc: Taeung Song <taeung@reallinux.co.kr> Cc: linuxgeek@linuxgeek.io Signed-off-by: Wonhyuk Yang <vvghjk1234@gmail.com> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent c4f135d commit 873a400

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

include/trace/events/workqueue.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ struct pool_workqueue;
2222
*/
2323
TRACE_EVENT(workqueue_queue_work,
2424

25-
TP_PROTO(unsigned int req_cpu, struct pool_workqueue *pwq,
25+
TP_PROTO(int req_cpu, struct pool_workqueue *pwq,
2626
struct work_struct *work),
2727

2828
TP_ARGS(req_cpu, pwq, work),
@@ -31,8 +31,8 @@ TRACE_EVENT(workqueue_queue_work,
3131
__field( void *, work )
3232
__field( void *, function)
3333
__string( workqueue, pwq->wq->name)
34-
__field( unsigned int, req_cpu )
35-
__field( unsigned int, cpu )
34+
__field( int, req_cpu )
35+
__field( int, cpu )
3636
),
3737

3838
TP_fast_assign(
@@ -43,7 +43,7 @@ TRACE_EVENT(workqueue_queue_work,
4343
__entry->cpu = pwq->pool->cpu;
4444
),
4545

46-
TP_printk("work struct=%p function=%ps workqueue=%s req_cpu=%u cpu=%u",
46+
TP_printk("work struct=%p function=%ps workqueue=%s req_cpu=%d cpu=%d",
4747
__entry->work, __entry->function, __get_str(workqueue),
4848
__entry->req_cpu, __entry->cpu)
4949
);

0 commit comments

Comments
 (0)