Skip to content

Commit 8567263

Browse files
committed
Merge tag 'for-6.10/dm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm
Pull device mapper fixes from Mike Snitzer: - Fix DM discard regressions due to DM core switching over to using queue_limits_set() without DM core and targets first being updated to set (and stack) discard limits in terms of max_hw_discard_sectors and not max_discard_sectors - Fix stable@ DM integrity discard support to set device's discard_granularity limit to the device's logical block size * tag 'for-6.10/dm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm: dm: always manage discard support in terms of max_hw_discard_sectors dm-integrity: set discard_granularity to logical block size
2 parents 98f312b + 825d8bb commit 8567263

File tree

10 files changed

+10
-13
lines changed

10 files changed

+10
-13
lines changed

drivers/md/dm-cache-target.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3390,8 +3390,8 @@ static void set_discard_limits(struct cache *cache, struct queue_limits *limits)
33903390

33913391
if (!cache->features.discard_passdown) {
33923392
/* No passdown is done so setting own virtual limits */
3393-
limits->max_discard_sectors = min_t(sector_t, cache->discard_block_size * 1024,
3394-
cache->origin_sectors);
3393+
limits->max_hw_discard_sectors = min_t(sector_t, cache->discard_block_size * 1024,
3394+
cache->origin_sectors);
33953395
limits->discard_granularity = cache->discard_block_size << SECTOR_SHIFT;
33963396
return;
33973397
}
@@ -3400,7 +3400,6 @@ static void set_discard_limits(struct cache *cache, struct queue_limits *limits)
34003400
* cache_iterate_devices() is stacking both origin and fast device limits
34013401
* but discards aren't passed to fast device, so inherit origin's limits.
34023402
*/
3403-
limits->max_discard_sectors = origin_limits->max_discard_sectors;
34043403
limits->max_hw_discard_sectors = origin_limits->max_hw_discard_sectors;
34053404
limits->discard_granularity = origin_limits->discard_granularity;
34063405
limits->discard_alignment = origin_limits->discard_alignment;

drivers/md/dm-clone-target.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2046,7 +2046,8 @@ static void set_discard_limits(struct clone *clone, struct queue_limits *limits)
20462046
if (!test_bit(DM_CLONE_DISCARD_PASSDOWN, &clone->flags)) {
20472047
/* No passdown is done so we set our own virtual limits */
20482048
limits->discard_granularity = clone->region_size << SECTOR_SHIFT;
2049-
limits->max_discard_sectors = round_down(UINT_MAX >> SECTOR_SHIFT, clone->region_size);
2049+
limits->max_hw_discard_sectors = round_down(UINT_MAX >> SECTOR_SHIFT,
2050+
clone->region_size);
20502051
return;
20512052
}
20522053

@@ -2055,7 +2056,6 @@ static void set_discard_limits(struct clone *clone, struct queue_limits *limits)
20552056
* device limits but discards aren't passed to the source device, so
20562057
* inherit destination's limits.
20572058
*/
2058-
limits->max_discard_sectors = dest_limits->max_discard_sectors;
20592059
limits->max_hw_discard_sectors = dest_limits->max_hw_discard_sectors;
20602060
limits->discard_granularity = dest_limits->discard_granularity;
20612061
limits->discard_alignment = dest_limits->discard_alignment;

drivers/md/dm-integrity.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3492,6 +3492,7 @@ static void dm_integrity_io_hints(struct dm_target *ti, struct queue_limits *lim
34923492
limits->physical_block_size = ic->sectors_per_block << SECTOR_SHIFT;
34933493
blk_limits_io_min(limits, ic->sectors_per_block << SECTOR_SHIFT);
34943494
limits->dma_alignment = limits->logical_block_size - 1;
3495+
limits->discard_granularity = ic->sectors_per_block << SECTOR_SHIFT;
34953496
}
34963497
limits->max_integrity_segments = USHRT_MAX;
34973498
}

drivers/md/dm-log-writes.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -871,7 +871,7 @@ static void log_writes_io_hints(struct dm_target *ti, struct queue_limits *limit
871871
if (!bdev_max_discard_sectors(lc->dev->bdev)) {
872872
lc->device_supports_discard = false;
873873
limits->discard_granularity = lc->sectorsize;
874-
limits->max_discard_sectors = (UINT_MAX >> SECTOR_SHIFT);
874+
limits->max_hw_discard_sectors = (UINT_MAX >> SECTOR_SHIFT);
875875
}
876876
limits->logical_block_size = bdev_logical_block_size(lc->dev->bdev);
877877
limits->physical_block_size = bdev_physical_block_size(lc->dev->bdev);

drivers/md/dm-snap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2410,7 +2410,7 @@ static void snapshot_io_hints(struct dm_target *ti, struct queue_limits *limits)
24102410

24112411
/* All discards are split on chunk_size boundary */
24122412
limits->discard_granularity = snap->store->chunk_size;
2413-
limits->max_discard_sectors = snap->store->chunk_size;
2413+
limits->max_hw_discard_sectors = snap->store->chunk_size;
24142414

24152415
up_read(&_origins_lock);
24162416
}

drivers/md/dm-target.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,6 @@ static int io_err_iterate_devices(struct dm_target *ti,
249249

250250
static void io_err_io_hints(struct dm_target *ti, struct queue_limits *limits)
251251
{
252-
limits->max_discard_sectors = UINT_MAX;
253252
limits->max_hw_discard_sectors = UINT_MAX;
254253
limits->discard_granularity = 512;
255254
}

drivers/md/dm-thin.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4094,7 +4094,7 @@ static void pool_io_hints(struct dm_target *ti, struct queue_limits *limits)
40944094
if (pt->adjusted_pf.discard_enabled) {
40954095
disable_discard_passdown_if_not_supported(pt);
40964096
if (!pt->adjusted_pf.discard_passdown)
4097-
limits->max_discard_sectors = 0;
4097+
limits->max_hw_discard_sectors = 0;
40984098
/*
40994099
* The pool uses the same discard limits as the underlying data
41004100
* device. DM core has already set this up.
@@ -4491,7 +4491,7 @@ static void thin_io_hints(struct dm_target *ti, struct queue_limits *limits)
44914491

44924492
if (pool->pf.discard_enabled) {
44934493
limits->discard_granularity = pool->sectors_per_block << SECTOR_SHIFT;
4494-
limits->max_discard_sectors = pool->sectors_per_block * BIO_PRISON_MAX_RANGE;
4494+
limits->max_hw_discard_sectors = pool->sectors_per_block * BIO_PRISON_MAX_RANGE;
44954495
}
44964496
}
44974497

drivers/md/dm-zero.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ static int zero_map(struct dm_target *ti, struct bio *bio)
6161

6262
static void zero_io_hints(struct dm_target *ti, struct queue_limits *limits)
6363
{
64-
limits->max_discard_sectors = UINT_MAX;
6564
limits->max_hw_discard_sectors = UINT_MAX;
6665
limits->discard_granularity = 512;
6766
}

drivers/md/dm-zoned-target.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1001,7 +1001,6 @@ static void dmz_io_hints(struct dm_target *ti, struct queue_limits *limits)
10011001

10021002
limits->discard_alignment = 0;
10031003
limits->discard_granularity = DMZ_BLOCK_SIZE;
1004-
limits->max_discard_sectors = chunk_sectors;
10051004
limits->max_hw_discard_sectors = chunk_sectors;
10061005
limits->max_write_zeroes_sectors = chunk_sectors;
10071006

drivers/md/dm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,7 @@ void disable_discard(struct mapped_device *md)
10861086
struct queue_limits *limits = dm_get_queue_limits(md);
10871087

10881088
/* device doesn't really support DISCARD, disable it */
1089-
limits->max_discard_sectors = 0;
1089+
limits->max_hw_discard_sectors = 0;
10901090
}
10911091

10921092
void disable_write_zeroes(struct mapped_device *md)

0 commit comments

Comments
 (0)