Skip to content

Commit 8502950

Browse files
committed
Merge tag 'mmc-v5.19-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
Pull MMC fix from Ulf Hansson: - sdhci-omap: Fix a lockdep warning while probing * tag 'mmc-v5.19-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc: mmc: sdhci-omap: Fix a lockdep warning for PM runtime init
2 parents 8e65afb + 51189eb commit 8502950

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

drivers/mmc/host/sdhci-omap.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1298,8 +1298,9 @@ static int sdhci_omap_probe(struct platform_device *pdev)
12981298
/*
12991299
* omap_device_pm_domain has callbacks to enable the main
13001300
* functional clock, interface clock and also configure the
1301-
* SYSCONFIG register of omap devices. The callback will be invoked
1302-
* as part of pm_runtime_get_sync.
1301+
* SYSCONFIG register to clear any boot loader set voltage
1302+
* capabilities before calling sdhci_setup_host(). The
1303+
* callback will be invoked as part of pm_runtime_get_sync.
13031304
*/
13041305
pm_runtime_use_autosuspend(dev);
13051306
pm_runtime_set_autosuspend_delay(dev, 50);
@@ -1441,7 +1442,8 @@ static int __maybe_unused sdhci_omap_runtime_suspend(struct device *dev)
14411442
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
14421443
struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
14431444

1444-
sdhci_runtime_suspend_host(host);
1445+
if (omap_host->con != -EINVAL)
1446+
sdhci_runtime_suspend_host(host);
14451447

14461448
sdhci_omap_context_save(omap_host);
14471449

@@ -1458,10 +1460,10 @@ static int __maybe_unused sdhci_omap_runtime_resume(struct device *dev)
14581460

14591461
pinctrl_pm_select_default_state(dev);
14601462

1461-
if (omap_host->con != -EINVAL)
1463+
if (omap_host->con != -EINVAL) {
14621464
sdhci_omap_context_restore(omap_host);
1463-
1464-
sdhci_runtime_resume_host(host, 0);
1465+
sdhci_runtime_resume_host(host, 0);
1466+
}
14651467

14661468
return 0;
14671469
}

0 commit comments

Comments
 (0)