Skip to content

Commit 763865f

Browse files
zhijianli88hdeller
authored andcommitted
fbdev: panel-tpo-td043mtea1: Convert sprintf() to sysfs_emit()
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). CC: Helge Deller <deller@gmx.de> CC: linux-omap@vger.kernel.org CC: linux-fbdev@vger.kernel.org CC: dri-devel@lists.freedesktop.org Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent c2d9532 commit 763865f

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -225,17 +225,12 @@ static ssize_t tpo_td043_gamma_show(struct device *dev,
225225
{
226226
struct panel_drv_data *ddata = dev_get_drvdata(dev);
227227
ssize_t len = 0;
228-
int ret;
229228
int i;
230229

231-
for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++) {
232-
ret = snprintf(buf + len, PAGE_SIZE - len, "%u ",
233-
ddata->gamma[i]);
234-
if (ret < 0)
235-
return ret;
236-
len += ret;
237-
}
238-
buf[len - 1] = '\n';
230+
for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++)
231+
len += sysfs_emit_at(buf, len, "%u ", ddata->gamma[i]);
232+
if (len)
233+
buf[len - 1] = '\n';
239234

240235
return len;
241236
}

0 commit comments

Comments
 (0)