Skip to content

Commit 6dfeb04

Browse files
committed
Merge tag 'sound-6.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
Pull sound fixes from Takashi Iwai: "A collection of small fixes. Half of them are HD-audio quirks while the rest are various device-specific ASoC fixes" * tag 'sound-6.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: ASoC: wm8962: Fix up incorrect error message in wm8962_set_fll ASoC: wm8962: Enable both SPKOUTR_ENA and SPKOUTL_ENA in mono mode ASoC: wm8962: Enable oscillator if selecting WM8962_FLL_OSC ASoC: dt-bindings: nvidia: Fix 'lge' vendor prefix ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook ASoC: amd: yc: Add HP Pavilion Aero Laptop 13-be2xxx(8BD6) into DMI quirk table ASoC: rcar: adg: correct TIMSEL setting for SSI9 ALSA: hda: cs35l41: Overwrite CS35L41 configuration for ASUS UM5302LA ALSA: hda/realtek: Add quirks for Lenovo Thinkbook 16P laptops ALSA: hda: cs35l41: Support Lenovo Thinkbook 16P ALSA: hda/realtek - Add Headset Mic supported Acer NB platform ALSA: hda: optimize the probe codec process ALSA: hda/realtek - Fix headset Mic no show at resume back for Lenovo ALC897 platform ASoC: Intel: bytcr_rt5640: Add an extra entry for the Chuwi Vi8 tablet ASoC: madera: Fix typo in madera_set_fll_clks shift value
2 parents e6fac3c + 21e59fe commit 6dfeb04

File tree

9 files changed

+69
-14
lines changed

9 files changed

+69
-14
lines changed

Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ examples:
6464
#include <dt-bindings/clock/tegra30-car.h>
6565
#include <dt-bindings/soc/tegra-pmc.h>
6666
sound {
67-
compatible = "lge,tegra-audio-max98089-p895",
67+
compatible = "lg,tegra-audio-max98089-p895",
6868
"nvidia,tegra-audio-max98089";
6969
nvidia,model = "LG Optimus Vu MAX98089";
7070

sound/pci/hda/cs35l41_hda_property.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
8383
{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
8484
{ "10431863", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
8585
{ "104318D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
86+
{ "10431A83", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
8687
{ "10431C9F", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
8788
{ "10431CAF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
8889
{ "10431CCF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
@@ -97,6 +98,8 @@ static const struct cs35l41_config cs35l41_config_table[] = {
9798
{ "10431F1F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
9899
{ "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
99100
{ "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
101+
{ "17AA38A9", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
102+
{ "17AA38AB", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
100103
{ "17AA38B4", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
101104
{ "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
102105
{ "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
@@ -421,6 +424,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
421424
{ "CSC3551", "104317F3", generic_dsd_config },
422425
{ "CSC3551", "10431863", generic_dsd_config },
423426
{ "CSC3551", "104318D3", generic_dsd_config },
427+
{ "CSC3551", "10431A83", generic_dsd_config },
424428
{ "CSC3551", "10431C9F", generic_dsd_config },
425429
{ "CSC3551", "10431CAF", generic_dsd_config },
426430
{ "CSC3551", "10431CCF", generic_dsd_config },
@@ -435,6 +439,8 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
435439
{ "CSC3551", "10431F1F", generic_dsd_config },
436440
{ "CSC3551", "10431F62", generic_dsd_config },
437441
{ "CSC3551", "17AA386F", generic_dsd_config },
442+
{ "CSC3551", "17AA38A9", generic_dsd_config },
443+
{ "CSC3551", "17AA38AB", generic_dsd_config },
438444
{ "CSC3551", "17AA38B4", generic_dsd_config },
439445
{ "CSC3551", "17AA38B5", generic_dsd_config },
440446
{ "CSC3551", "17AA38B6", generic_dsd_config },

sound/pci/hda/hda_controller.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,6 +1207,9 @@ int azx_probe_codecs(struct azx *chip, unsigned int max_slots)
12071207
dev_warn(chip->card->dev,
12081208
"Codec #%d probe error; disabling it...\n", c);
12091209
bus->codec_mask &= ~(1 << c);
1210+
/* no codecs */
1211+
if (bus->codec_mask == 0)
1212+
break;
12101213
/* More badly, accessing to a non-existing
12111214
* codec often screws up the controller chip,
12121215
* and disturbs the further communications.

sound/pci/hda/patch_realtek.c

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9996,6 +9996,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
99969996
SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
99979997
SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
99989998
SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
9999+
SND_PCI_QUIRK(0x103c, 0x8c8a, "HP EliteBook 630", ALC236_FIXUP_HP_GPIO_LED),
10000+
SND_PCI_QUIRK(0x103c, 0x8c8c, "HP EliteBook 660", ALC236_FIXUP_HP_GPIO_LED),
10001+
SND_PCI_QUIRK(0x103c, 0x8c90, "HP EliteBook 640", ALC236_FIXUP_HP_GPIO_LED),
10002+
SND_PCI_QUIRK(0x103c, 0x8c91, "HP EliteBook 660", ALC236_FIXUP_HP_GPIO_LED),
999910003
SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
1000010004
SND_PCI_QUIRK(0x103c, 0x8c97, "HP ZBook", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
1000110005
SND_PCI_QUIRK(0x103c, 0x8ca1, "HP ZBook Power", ALC236_FIXUP_HP_GPIO_LED),
@@ -10303,6 +10307,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
1030310307
SND_PCI_QUIRK(0x17aa, 0x3886, "Y780 VECO DUAL", ALC287_FIXUP_TAS2781_I2C),
1030410308
SND_PCI_QUIRK(0x17aa, 0x38a7, "Y780P AMD YG dual", ALC287_FIXUP_TAS2781_I2C),
1030510309
SND_PCI_QUIRK(0x17aa, 0x38a8, "Y780P AMD VECO dual", ALC287_FIXUP_TAS2781_I2C),
10310+
SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P", ALC287_FIXUP_CS35L41_I2C_2),
10311+
SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P", ALC287_FIXUP_CS35L41_I2C_2),
1030610312
SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
1030710313
SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
1030810314
SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
@@ -10995,6 +11001,8 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
1099511001
* at most one tbl is allowed to define for the same vendor and same codec
1099611002
*/
1099711003
static const struct snd_hda_pin_quirk alc269_fallback_pin_fixup_tbl[] = {
11004+
SND_HDA_PIN_QUIRK(0x10ec0256, 0x1025, "Acer", ALC2XX_FIXUP_HEADSET_MIC,
11005+
{0x19, 0x40000000}),
1099811006
SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE,
1099911007
{0x19, 0x40000000},
1100011008
{0x1b, 0x40000000}),
@@ -11684,8 +11692,7 @@ static void alc897_hp_automute_hook(struct hda_codec *codec,
1168411692

1168511693
snd_hda_gen_hp_automute(codec, jack);
1168611694
vref = spec->gen.hp_jack_present ? (PIN_HP | AC_PINCTL_VREF_100) : PIN_HP;
11687-
snd_hda_codec_write(codec, 0x1b, 0, AC_VERB_SET_PIN_WIDGET_CONTROL,
11688-
vref);
11695+
snd_hda_set_pin_ctl(codec, 0x1b, vref);
1168911696
}
1169011697

1169111698
static void alc897_fixup_lenovo_headset_mic(struct hda_codec *codec,
@@ -11694,6 +11701,10 @@ static void alc897_fixup_lenovo_headset_mic(struct hda_codec *codec,
1169411701
struct alc_spec *spec = codec->spec;
1169511702
if (action == HDA_FIXUP_ACT_PRE_PROBE) {
1169611703
spec->gen.hp_automute_hook = alc897_hp_automute_hook;
11704+
spec->no_shutup_pins = 1;
11705+
}
11706+
if (action == HDA_FIXUP_ACT_PROBE) {
11707+
snd_hda_set_pin_ctl_cache(codec, 0x1a, PIN_IN | AC_PINCTL_VREF_100);
1169711708
}
1169811709
}
1169911710

sound/soc/amd/yc/acp6x-mach.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -416,6 +416,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
416416
DMI_MATCH(DMI_BOARD_NAME, "8B2F"),
417417
}
418418
},
419+
{
420+
.driver_data = &acp6x_card,
421+
.matches = {
422+
DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
423+
DMI_MATCH(DMI_BOARD_NAME, "8BD6"),
424+
}
425+
},
419426
{
420427
.driver_data = &acp6x_card,
421428
.matches = {

sound/soc/codecs/madera.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3884,7 +3884,7 @@ static inline int madera_set_fll_clks(struct madera_fll *fll, int base, bool ena
38843884
return madera_set_fll_clks_reg(fll, ena,
38853885
base + MADERA_FLL_CONTROL_6_OFFS,
38863886
MADERA_FLL1_REFCLK_SRC_MASK,
3887-
MADERA_FLL1_REFCLK_DIV_SHIFT);
3887+
MADERA_FLL1_REFCLK_SRC_SHIFT);
38883888
}
38893889

38903890
static inline int madera_set_fllao_clks(struct madera_fll *fll, int base, bool ena)

sound/soc/codecs/wm8962.c

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2229,14 +2229,16 @@ SND_SOC_DAPM_PGA_E("HPOUT", SND_SOC_NOPM, 0, 0, NULL, 0, hp_event,
22292229

22302230
SND_SOC_DAPM_OUTPUT("HPOUTL"),
22312231
SND_SOC_DAPM_OUTPUT("HPOUTR"),
2232+
2233+
SND_SOC_DAPM_PGA("SPKOUTL Output", WM8962_CLASS_D_CONTROL_1, 6, 0, NULL, 0),
2234+
SND_SOC_DAPM_PGA("SPKOUTR Output", WM8962_CLASS_D_CONTROL_1, 7, 0, NULL, 0),
22322235
};
22332236

22342237
static const struct snd_soc_dapm_widget wm8962_dapm_spk_mono_widgets[] = {
22352238
SND_SOC_DAPM_MIXER("Speaker Mixer", WM8962_MIXER_ENABLES, 1, 0,
22362239
spkmixl, ARRAY_SIZE(spkmixl)),
22372240
SND_SOC_DAPM_MUX_E("Speaker PGA", WM8962_PWR_MGMT_2, 4, 0, &spkoutl_mux,
22382241
out_pga_event, SND_SOC_DAPM_POST_PMU),
2239-
SND_SOC_DAPM_PGA("Speaker Output", WM8962_CLASS_D_CONTROL_1, 7, 0, NULL, 0),
22402242
SND_SOC_DAPM_OUTPUT("SPKOUT"),
22412243
};
22422244

@@ -2251,9 +2253,6 @@ SND_SOC_DAPM_MUX_E("SPKOUTL PGA", WM8962_PWR_MGMT_2, 4, 0, &spkoutl_mux,
22512253
SND_SOC_DAPM_MUX_E("SPKOUTR PGA", WM8962_PWR_MGMT_2, 3, 0, &spkoutr_mux,
22522254
out_pga_event, SND_SOC_DAPM_POST_PMU),
22532255

2254-
SND_SOC_DAPM_PGA("SPKOUTR Output", WM8962_CLASS_D_CONTROL_1, 7, 0, NULL, 0),
2255-
SND_SOC_DAPM_PGA("SPKOUTL Output", WM8962_CLASS_D_CONTROL_1, 6, 0, NULL, 0),
2256-
22572256
SND_SOC_DAPM_OUTPUT("SPKOUTL"),
22582257
SND_SOC_DAPM_OUTPUT("SPKOUTR"),
22592258
};
@@ -2366,12 +2365,18 @@ static const struct snd_soc_dapm_route wm8962_spk_mono_intercon[] = {
23662365
{ "Speaker PGA", "Mixer", "Speaker Mixer" },
23672366
{ "Speaker PGA", "DAC", "DACL" },
23682367

2369-
{ "Speaker Output", NULL, "Speaker PGA" },
2370-
{ "Speaker Output", NULL, "SYSCLK" },
2371-
{ "Speaker Output", NULL, "TOCLK" },
2372-
{ "Speaker Output", NULL, "TEMP_SPK" },
2368+
{ "SPKOUTL Output", NULL, "Speaker PGA" },
2369+
{ "SPKOUTL Output", NULL, "SYSCLK" },
2370+
{ "SPKOUTL Output", NULL, "TOCLK" },
2371+
{ "SPKOUTL Output", NULL, "TEMP_SPK" },
23732372

2374-
{ "SPKOUT", NULL, "Speaker Output" },
2373+
{ "SPKOUTR Output", NULL, "Speaker PGA" },
2374+
{ "SPKOUTR Output", NULL, "SYSCLK" },
2375+
{ "SPKOUTR Output", NULL, "TOCLK" },
2376+
{ "SPKOUTR Output", NULL, "TEMP_SPK" },
2377+
2378+
{ "SPKOUT", NULL, "SPKOUTL Output" },
2379+
{ "SPKOUT", NULL, "SPKOUTR Output" },
23752380
};
23762381

23772382
static const struct snd_soc_dapm_route wm8962_spk_stereo_intercon[] = {
@@ -2914,8 +2919,12 @@ static int wm8962_set_fll(struct snd_soc_component *component, int fll_id, int s
29142919
switch (fll_id) {
29152920
case WM8962_FLL_MCLK:
29162921
case WM8962_FLL_BCLK:
2922+
fll1 |= (fll_id - 1) << WM8962_FLL_REFCLK_SRC_SHIFT;
2923+
break;
29172924
case WM8962_FLL_OSC:
29182925
fll1 |= (fll_id - 1) << WM8962_FLL_REFCLK_SRC_SHIFT;
2926+
snd_soc_component_update_bits(component, WM8962_PLL2,
2927+
WM8962_OSC_ENA, WM8962_OSC_ENA);
29192928
break;
29202929
case WM8962_FLL_INT:
29212930
snd_soc_component_update_bits(component, WM8962_FLL_CONTROL_1,
@@ -2924,7 +2933,7 @@ static int wm8962_set_fll(struct snd_soc_component *component, int fll_id, int s
29242933
WM8962_FLL_FRC_NCO, WM8962_FLL_FRC_NCO);
29252934
break;
29262935
default:
2927-
dev_err(component->dev, "Unknown FLL source %d\n", ret);
2936+
dev_err(component->dev, "Unknown FLL source %d\n", source);
29282937
return -EINVAL;
29292938
}
29302939

sound/soc/intel/boards/bytcr_rt5640.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -685,6 +685,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
685685
BYT_RT5640_SSP0_AIF1 |
686686
BYT_RT5640_MCLK_EN),
687687
},
688+
{ /* Chuwi Vi8 dual-boot (CWI506) */
689+
.matches = {
690+
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
691+
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "i86"),
692+
/* The above are too generic, also match BIOS info */
693+
DMI_MATCH(DMI_BIOS_VERSION, "CHUWI2.D86JHBNR02"),
694+
},
695+
.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
696+
BYT_RT5640_MONO_SPEAKER |
697+
BYT_RT5640_SSP0_AIF1 |
698+
BYT_RT5640_MCLK_EN),
699+
},
688700
{
689701
/* Chuwi Vi10 (CWI505) */
690702
.matches = {

sound/soc/sh/rcar/adg.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,13 @@ static u32 rsnd_adg_ssi_ws_timing_gen2(struct rsnd_dai_stream *io)
111111
ws = 7;
112112
break;
113113
}
114+
} else {
115+
/*
116+
* SSI8 is not connected to ADG.
117+
* Thus SSI9 is using ws = 8
118+
*/
119+
if (id == 9)
120+
ws = 8;
114121
}
115122

116123
return (0x6 + ws) << 8;

0 commit comments

Comments
 (0)