Skip to content

Commit 6a9a52f

Browse files
Dawei LiKAGA-KOKO
authored andcommitted
irqchip/irq-bcm6345-l1: Avoid explicit cpumask allocation on stack
In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. Use cpumask_first_and_and() to avoid the need for a temporary cpumask on the stack. Signed-off-by: Dawei Li <dawei.li@shingroup.cn> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/20240416085454.3547175-3-dawei.li@shingroup.cn
1 parent cdc6655 commit 6a9a52f

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/irqchip/irq-bcm6345-l1.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,14 +192,10 @@ static int bcm6345_l1_set_affinity(struct irq_data *d,
192192
u32 mask = BIT(d->hwirq % IRQS_PER_WORD);
193193
unsigned int old_cpu = cpu_for_irq(intc, d);
194194
unsigned int new_cpu;
195-
struct cpumask valid;
196195
unsigned long flags;
197196
bool enabled;
198197

199-
if (!cpumask_and(&valid, &intc->cpumask, dest))
200-
return -EINVAL;
201-
202-
new_cpu = cpumask_any_and(&valid, cpu_online_mask);
198+
new_cpu = cpumask_first_and_and(&intc->cpumask, dest, cpu_online_mask);
203199
if (new_cpu >= nr_cpu_ids)
204200
return -EINVAL;
205201

0 commit comments

Comments
 (0)