Skip to content

Commit 5b142b3

Browse files
dhowellsSteve French
authored andcommitted
cifs: Move some extern decls from .c files to .h
Move the following: extern mempool_t *cifs_sm_req_poolp; extern mempool_t *cifs_req_poolp; extern mempool_t *cifs_mid_poolp; extern bool disable_legacy_dialects; from various .c files to cifsglob.h. Signed-off-by: David Howells <dhowells@redhat.com> cc: linux-cifs@vger.kernel.org Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 2760161 commit 5b142b3

File tree

4 files changed

+2
-10
lines changed

4 files changed

+2
-10
lines changed

fs/smb/client/cifsfs.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,6 @@ MODULE_PARM_DESC(disable_legacy_dialects, "To improve security it may be "
151151
"vers=1.0 (CIFS/SMB1) and vers=2.0 are weaker"
152152
" and less secure. Default: n/N/0");
153153

154-
extern mempool_t *cifs_sm_req_poolp;
155-
extern mempool_t *cifs_req_poolp;
156-
extern mempool_t *cifs_mid_poolp;
157-
158154
struct workqueue_struct *cifsiod_wq;
159155
struct workqueue_struct *decrypt_wq;
160156
struct workqueue_struct *fileinfo_put_wq;

fs/smb/client/cifsglob.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2107,6 +2107,8 @@ extern struct workqueue_struct *cifsoplockd_wq;
21072107
extern struct workqueue_struct *deferredclose_wq;
21082108
extern __u32 cifs_lock_secret;
21092109

2110+
extern mempool_t *cifs_sm_req_poolp;
2111+
extern mempool_t *cifs_req_poolp;
21102112
extern mempool_t *cifs_mid_poolp;
21112113

21122114
/* Operations for different SMB versions */

fs/smb/client/connect.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@
5252
#include "fs_context.h"
5353
#include "cifs_swn.h"
5454

55-
extern mempool_t *cifs_req_poolp;
56-
extern bool disable_legacy_dialects;
57-
5855
/* FIXME: should these be tunable? */
5956
#define TLINK_ERROR_EXPIRE (1 * HZ)
6057
#define TLINK_IDLE_EXPIRE (600 * HZ)

fs/smb/client/misc.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@
2727
#include "fs_context.h"
2828
#include "cached_dir.h"
2929

30-
extern mempool_t *cifs_sm_req_poolp;
31-
extern mempool_t *cifs_req_poolp;
32-
3330
/* The xid serves as a useful identifier for each incoming vfs request,
3431
in a similar way to the mid which is useful to track each sent smb,
3532
and CurrentXid can also provide a running counter (although it

0 commit comments

Comments
 (0)