Skip to content

Commit 4d08246

Browse files
krzkstorulf
authored andcommitted
pmdomain: core: constify of_phandle_args in xlate
The xlate callbacks are supposed to translate of_phandle_args to proper provider without modifying the of_phandle_args. Make the argument pointer to const for code safety and readability. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20240208202822.631449-1-krzysztof.kozlowski@linaro.org Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 693c301 commit 4d08246

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

drivers/pmdomain/core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2266,7 +2266,7 @@ static DEFINE_MUTEX(of_genpd_mutex);
22662266
* to be a valid pointer to struct generic_pm_domain.
22672267
*/
22682268
static struct generic_pm_domain *genpd_xlate_simple(
2269-
struct of_phandle_args *genpdspec,
2269+
const struct of_phandle_args *genpdspec,
22702270
void *data)
22712271
{
22722272
return data;
@@ -2283,7 +2283,7 @@ static struct generic_pm_domain *genpd_xlate_simple(
22832283
* the genpd_onecell_data struct when registering the provider.
22842284
*/
22852285
static struct generic_pm_domain *genpd_xlate_onecell(
2286-
struct of_phandle_args *genpdspec,
2286+
const struct of_phandle_args *genpdspec,
22872287
void *data)
22882288
{
22892289
struct genpd_onecell_data *genpd_data = data;

drivers/pmdomain/imx/scu-pd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ static int imx_sc_pd_power_off(struct generic_pm_domain *domain)
393393
return imx_sc_pd_power(domain, false);
394394
}
395395

396-
static struct generic_pm_domain *imx_scu_pd_xlate(struct of_phandle_args *spec,
396+
static struct generic_pm_domain *imx_scu_pd_xlate(const struct of_phandle_args *spec,
397397
void *data)
398398
{
399399
struct generic_pm_domain *domain = ERR_PTR(-ENOENT);

drivers/pmdomain/tegra/powergate-bpmp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ static void tegra_bpmp_remove_powergates(struct tegra_bpmp *bpmp)
305305
}
306306

307307
static struct generic_pm_domain *
308-
tegra_powergate_xlate(struct of_phandle_args *spec, void *data)
308+
tegra_powergate_xlate(const struct of_phandle_args *spec, void *data)
309309
{
310310
struct generic_pm_domain *domain = ERR_PTR(-ENOENT);
311311
struct genpd_onecell_data *genpd = data;

drivers/pmdomain/ti/ti_sci_pm_domains.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ static int ti_sci_pd_power_on(struct generic_pm_domain *domain)
8585
* @data: genpd core data for all the powerdomains on the device
8686
*/
8787
static struct generic_pm_domain *ti_sci_pd_xlate(
88-
struct of_phandle_args *genpdspec,
88+
const struct of_phandle_args *genpdspec,
8989
void *data)
9090
{
9191
struct genpd_onecell_data *genpd_data = data;

drivers/pmdomain/xilinx/zynqmp-pm-domains.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ static void zynqmp_gpd_detach_dev(struct generic_pm_domain *domain,
210210
}
211211

212212
static struct generic_pm_domain *zynqmp_gpd_xlate
213-
(struct of_phandle_args *genpdspec, void *data)
213+
(const struct of_phandle_args *genpdspec, void *data)
214214
{
215215
struct genpd_onecell_data *genpd_data = data;
216216
unsigned int i, idx = genpdspec->args[0];

include/linux/pm_domain.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ static inline void dev_pm_genpd_resume(struct device *dev) {}
349349
/* OF PM domain providers */
350350
struct of_device_id;
351351

352-
typedef struct generic_pm_domain *(*genpd_xlate_t)(struct of_phandle_args *args,
352+
typedef struct generic_pm_domain *(*genpd_xlate_t)(const struct of_phandle_args *args,
353353
void *data);
354354

355355
struct genpd_onecell_data {

0 commit comments

Comments
 (0)