Skip to content

Commit 497041d

Browse files
dangowrtkuba-moo
authored andcommitted
net: dsa: mt7530: sync driver-specific behavior of MT7531 variants
MT7531 standalone and MMIO variants found in MT7988 and EN7581 share most basic properties. Despite that, assisted_learning_on_cpu_port and mtu_enforcement_ingress were only applied for MT7531 but not for MT7988 or EN7581, causing the expected issues on MMIO devices. Apply both settings equally also for MT7988 and EN7581 by moving both assignments form mt7531_setup() to mt7531_setup_common(). This fixes unwanted flooding of packets due to unknown unicast during DA lookup, as well as issues with heterogenous MTU settings. Fixes: 7f54cc9 ("net: dsa: mt7530: split-off common parts from mt7531_setup") Signed-off-by: Daniel Golle <daniel@makrotopia.org> Reviewed-by: Chester A. Unal <chester.a.unal@arinc9.com> Link: https://patch.msgid.link/89ed7ec6d4fa0395ac53ad2809742bb1ce61ed12.1745290867.git.daniel@makrotopia.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent fa44042 commit 497041d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/dsa/mt7530.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2419,6 +2419,9 @@ mt7531_setup_common(struct dsa_switch *ds)
24192419
struct mt7530_priv *priv = ds->priv;
24202420
int ret, i;
24212421

2422+
ds->assisted_learning_on_cpu_port = true;
2423+
ds->mtu_enforcement_ingress = true;
2424+
24222425
mt753x_trap_frames(priv);
24232426

24242427
/* Enable and reset MIB counters */
@@ -2571,9 +2574,6 @@ mt7531_setup(struct dsa_switch *ds)
25712574
if (ret)
25722575
return ret;
25732576

2574-
ds->assisted_learning_on_cpu_port = true;
2575-
ds->mtu_enforcement_ingress = true;
2576-
25772577
return 0;
25782578
}
25792579

0 commit comments

Comments
 (0)