Skip to content

Commit 496d0a6

Browse files
parshuramsanglerafaeljw
authored andcommitted
cpuidle: haltpoll: do not shrink guest poll_limit_ns below grow_start
While adjusting guest halt poll limit, grow block starts at guest_halt_poll_grow_start without taking intermediate values. Similar behavior is expected while shrinking the value. This avoids short interval values which are really not required. VCPU1 trace (guest_halt_poll_shrink equals 2): VCPU1 grow 10000 VCPU1 shrink 5000 VCPU1 shrink 2500 VCPU1 shrink 1250 VCPU1 shrink 625 VCPU1 shrink 312 VCPU1 shrink 156 VCPU1 shrink 78 VCPU1 shrink 39 VCPU1 shrink 19 VCPU1 shrink 9 VCPU1 shrink 4 Similar change is done in KVM halt poll flow with below patch: Link: https://lore.kernel.org/kvm/20211006133021.271905-3-sashal@kernel.org/ Co-developed-by: Rajendran Jaishankar <jaishankar.rajendran@intel.com> Signed-off-by: Rajendran Jaishankar <jaishankar.rajendran@intel.com> Signed-off-by: Parshuram Sangle <parshuram.sangle@intel.com> Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com> [ rjw: Subject edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 841c351 commit 496d0a6

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

drivers/cpuidle/governors/haltpoll.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,15 @@ static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)
9898
unsigned int shrink = guest_halt_poll_shrink;
9999

100100
val = dev->poll_limit_ns;
101-
if (shrink == 0)
101+
if (shrink == 0) {
102102
val = 0;
103-
else
103+
} else {
104104
val /= shrink;
105+
/* Reset value to 0 if shrunk below grow_start */
106+
if (val < guest_halt_poll_grow_start)
107+
val = 0;
108+
}
109+
105110
trace_guest_halt_poll_ns_shrink(val, dev->poll_limit_ns);
106111
dev->poll_limit_ns = val;
107112
}

0 commit comments

Comments
 (0)