Skip to content

Commit 481ec3b

Browse files
andy-shevhcahca
authored andcommitted
s390/cio: use while (i--) pattern to clean up
Use more natural while (i--) pattern to clean up allocated resources. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com> Link: https://lore.kernel.org/r/20240222134501.236871-1-andriy.shevchenko@linux.intel.com Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
1 parent 69460c5 commit 481ec3b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/s390/cio/ccwgroup.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ static int __ccwgroup_create_symlinks(struct ccwgroup_device *gdev)
240240
rc = sysfs_create_link(&gdev->cdev[i]->dev.kobj,
241241
&gdev->dev.kobj, "group_device");
242242
if (rc) {
243-
for (--i; i >= 0; i--)
243+
while (i--)
244244
sysfs_remove_link(&gdev->cdev[i]->dev.kobj,
245245
"group_device");
246246
return rc;
@@ -251,7 +251,7 @@ static int __ccwgroup_create_symlinks(struct ccwgroup_device *gdev)
251251
rc = sysfs_create_link(&gdev->dev.kobj,
252252
&gdev->cdev[i]->dev.kobj, str);
253253
if (rc) {
254-
for (--i; i >= 0; i--) {
254+
while (i--) {
255255
sprintf(str, "cdev%d", i);
256256
sysfs_remove_link(&gdev->dev.kobj, str);
257257
}

drivers/s390/cio/chsc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -844,7 +844,7 @@ chsc_add_cmg_attr(struct channel_subsystem *css)
844844
}
845845
return ret;
846846
cleanup:
847-
for (--i; i >= 0; i--) {
847+
while (i--) {
848848
if (!css->chps[i])
849849
continue;
850850
chp_remove_cmg_attr(css->chps[i]);

0 commit comments

Comments
 (0)