Skip to content

Commit 4670c8c

Browse files
Sakari AilusHans Verkuil
authored andcommitted
media: ipu-bridge: Fix Kconfig dependencies
The current Kconfig symbol dependencies allow having the following Kconfig symbol values CONFIG_IPU_BRIDGE=m CONFIG_VIDEO_IPU3_CIO2=y CONFIG_CIO2_BRIDGE=n This does not work as the IPU bridge API is conditional to IS_ENABLED(CONFIG_IPU_BRIDGE). Fix this by changing the dependencies so that CONFIG_IPU_BRIDGE can be separately selected. The CONFIG_CIO2_BRIDGE symbol becomes redundant as a result and is removed. Fixes: 2545a2c ("media: ipu3-cio2: allow ipu_bridge to be a module again") Suggested-by: Arnd Bergmann <arnd@kernel.org> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent 760d03f commit 4670c8c

File tree

3 files changed

+16
-27
lines changed

3 files changed

+16
-27
lines changed

drivers/media/pci/intel/Kconfig

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
11
# SPDX-License-Identifier: GPL-2.0-only
2+
3+
source "drivers/media/pci/intel/ipu3/Kconfig"
4+
source "drivers/media/pci/intel/ivsc/Kconfig"
5+
26
config IPU_BRIDGE
3-
tristate
7+
tristate "Intel IPU Bridge"
48
depends on I2C && ACPI
59
help
6-
This is a helper module for the IPU bridge, which can be
7-
used by ipu3 and other drivers. In order to handle module
8-
dependencies, this is selected by each driver that needs it.
10+
The IPU bridge is a helper library for Intel IPU drivers to
11+
function on systems shipped with Windows.
912

10-
source "drivers/media/pci/intel/ipu3/Kconfig"
11-
source "drivers/media/pci/intel/ivsc/Kconfig"
13+
Currently used by the ipu3-cio2 and atomisp drivers.
14+
15+
Supported systems include:
16+
17+
- Microsoft Surface models (except Surface Pro 3)
18+
- The Lenovo Miix line (for example the 510, 520, 710 and 720)
19+
- Dell 7285

drivers/media/pci/intel/ipu3/Kconfig

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
config VIDEO_IPU3_CIO2
33
tristate "Intel ipu3-cio2 driver"
44
depends on VIDEO_DEV && PCI
5+
depends on IPU_BRIDGE || !IPU_BRIDGE
56
depends on ACPI || COMPILE_TEST
67
depends on X86
78
select MEDIA_CONTROLLER
89
select VIDEO_V4L2_SUBDEV_API
910
select V4L2_FWNODE
1011
select VIDEOBUF2_DMA_SG
11-
select IPU_BRIDGE if CIO2_BRIDGE
1212

1313
help
1414
This is the Intel IPU3 CIO2 CSI-2 receiver unit, found in Intel
@@ -18,22 +18,3 @@ config VIDEO_IPU3_CIO2
1818
Say Y or M here if you have a Skylake/Kaby Lake SoC with MIPI CSI-2
1919
connected camera.
2020
The module will be called ipu3-cio2.
21-
22-
config CIO2_BRIDGE
23-
bool "IPU3 CIO2 Sensors Bridge"
24-
depends on VIDEO_IPU3_CIO2 && ACPI
25-
depends on I2C
26-
help
27-
This extension provides an API for the ipu3-cio2 driver to create
28-
connections to cameras that are hidden in the SSDB buffer in ACPI.
29-
It can be used to enable support for cameras in detachable / hybrid
30-
devices that ship with Windows.
31-
32-
Say Y here if your device is a detachable / hybrid laptop that comes
33-
with Windows installed by the OEM, for example:
34-
35-
- Microsoft Surface models (except Surface Pro 3)
36-
- The Lenovo Miix line (for example the 510, 520, 710 and 720)
37-
- Dell 7285
38-
39-
If in doubt, say N here.

drivers/staging/media/atomisp/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ menuconfig INTEL_ATOMISP
1212
config VIDEO_ATOMISP
1313
tristate "Intel Atom Image Signal Processor Driver"
1414
depends on VIDEO_DEV && INTEL_ATOMISP
15+
depends on IPU_BRIDGE
1516
depends on MEDIA_PCI_SUPPORT
1617
depends on PMIC_OPREGION
1718
depends on I2C
1819
select V4L2_FWNODE
1920
select IOSF_MBI
20-
select IPU_BRIDGE
2121
select VIDEOBUF2_VMALLOC
2222
select VIDEO_V4L2_SUBDEV_API
2323
help

0 commit comments

Comments
 (0)