Skip to content

Commit 3876258

Browse files
jtlaytonchucklever
authored andcommitted
nfsd: remove obsolete comment from nfs4_alloc_stid
idr_alloc_cyclic() is what guarantees that now, not this long-gone trick. Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent d917d78 commit 3876258

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

fs/nfsd/nfs4state.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -946,15 +946,6 @@ struct nfs4_stid *nfs4_alloc_stid(struct nfs4_client *cl, struct kmem_cache *sla
946946
spin_lock_init(&stid->sc_lock);
947947
INIT_LIST_HEAD(&stid->sc_cp_list);
948948

949-
/*
950-
* It shouldn't be a problem to reuse an opaque stateid value.
951-
* I don't think it is for 4.1. But with 4.0 I worry that, for
952-
* example, a stray write retransmission could be accepted by
953-
* the server when it should have been rejected. Therefore,
954-
* adopt a trick from the sctp code to attempt to maximize the
955-
* amount of time until an id is reused, by ensuring they always
956-
* "increase" (mod INT_MAX):
957-
*/
958949
return stid;
959950
out_free:
960951
kmem_cache_free(slab, stid);

0 commit comments

Comments
 (0)