watchdog: wdat_wdt: Stop watchdog when uninstalling module

liuxp11 · Wim Van Sebroeck · commit 330415ebea81 · 2022-05-21T10:09:30.000+02:00
Test shows that wachdog still reboots machine after the module is removed. Use watchdog_stop_on_unregister to stop the watchdog on removing. Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> eviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/1650984810-6247-4-git-send-email-liuxp11@chinatelecom.cn Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c
@@ -463,6 +463,7 @@ static int wdat_wdt_probe(struct platform_device *pdev)
 
 	watchdog_set_nowayout(&wdat->wdd, nowayout);
 	watchdog_stop_on_reboot(&wdat->wdd);
+	watchdog_stop_on_unregister(&wdat->wdd);
 	return devm_watchdog_register_device(dev, &wdat->wdd);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -463,6 +463,7 @@ static int wdat_wdt_probe(struct platform_device *pdev)`
`463`	`463`
`464`	`464`	`watchdog_set_nowayout(&wdat->wdd, nowayout);`
`465`	`465`	`watchdog_stop_on_reboot(&wdat->wdd);`
	`466`	`+ watchdog_stop_on_unregister(&wdat->wdd);`
`466`	`467`	`return devm_watchdog_register_device(dev, &wdat->wdd);`
`467`	`468`	`}`
`468`	`469`