Skip to content

Commit 2dc4e0f

Browse files
committed
Merge tag 'block-6.6-2023-10-27' of git://git.kernel.dk/linux
Pull block fix from Jens Axboe: "Just a single fix for a potential divide-by-zero, introduced in this cycle" * tag 'block-6.6-2023-10-27' of git://git.kernel.dk/linux: blk-throttle: check for overflow in calculate_bytes_allowed
2 parents 832328c + 2dd710d commit 2dc4e0f

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

block/blk-throttle.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -723,6 +723,12 @@ static unsigned int calculate_io_allowed(u32 iops_limit,
723723

724724
static u64 calculate_bytes_allowed(u64 bps_limit, unsigned long jiffy_elapsed)
725725
{
726+
/*
727+
* Can result be wider than 64 bits?
728+
* We check against 62, not 64, due to ilog2 truncation.
729+
*/
730+
if (ilog2(bps_limit) + ilog2(jiffy_elapsed) - ilog2(HZ) > 62)
731+
return U64_MAX;
726732
return mul_u64_u64_div_u64(bps_limit, (u64)jiffy_elapsed, (u64)HZ);
727733
}
728734

0 commit comments

Comments
 (0)