Skip to content

Commit 295815f

Browse files
Dr. David Alan GilbertMikulas Patocka
authored andcommitted
dm vdo: Remove unused functions
get_data_vio_pool_active_discards() get_data_vio_pool_discard_limit() get_data_vio_pool_maximum_discards() set_data_vio_pool_discard_limit() are all unused since commit a9da0fb ("dm vdo: remove all sysfs interfaces") Remove them. Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Reviewed-by: Matthew Sakai <msakai@redhat.com> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
1 parent 3571fc2 commit 295815f

File tree

2 files changed

+0
-34
lines changed

2 files changed

+0
-34
lines changed

drivers/md/dm-vdo/data-vio.c

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,35 +1074,6 @@ void dump_data_vio_pool(struct data_vio_pool *pool, bool dump_vios)
10741074
spin_unlock(&pool->lock);
10751075
}
10761076

1077-
data_vio_count_t get_data_vio_pool_active_discards(struct data_vio_pool *pool)
1078-
{
1079-
return READ_ONCE(pool->discard_limiter.busy);
1080-
}
1081-
1082-
data_vio_count_t get_data_vio_pool_discard_limit(struct data_vio_pool *pool)
1083-
{
1084-
return READ_ONCE(pool->discard_limiter.limit);
1085-
}
1086-
1087-
data_vio_count_t get_data_vio_pool_maximum_discards(struct data_vio_pool *pool)
1088-
{
1089-
return READ_ONCE(pool->discard_limiter.max_busy);
1090-
}
1091-
1092-
int set_data_vio_pool_discard_limit(struct data_vio_pool *pool, data_vio_count_t limit)
1093-
{
1094-
if (get_data_vio_pool_request_limit(pool) < limit) {
1095-
// The discard limit may not be higher than the data_vio limit.
1096-
return -EINVAL;
1097-
}
1098-
1099-
spin_lock(&pool->lock);
1100-
pool->discard_limiter.limit = limit;
1101-
spin_unlock(&pool->lock);
1102-
1103-
return VDO_SUCCESS;
1104-
}
1105-
11061077
data_vio_count_t get_data_vio_pool_active_requests(struct data_vio_pool *pool)
11071078
{
11081079
return READ_ONCE(pool->limiter.busy);

drivers/md/dm-vdo/data-vio.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -336,11 +336,6 @@ void drain_data_vio_pool(struct data_vio_pool *pool, struct vdo_completion *comp
336336
void resume_data_vio_pool(struct data_vio_pool *pool, struct vdo_completion *completion);
337337

338338
void dump_data_vio_pool(struct data_vio_pool *pool, bool dump_vios);
339-
data_vio_count_t get_data_vio_pool_active_discards(struct data_vio_pool *pool);
340-
data_vio_count_t get_data_vio_pool_discard_limit(struct data_vio_pool *pool);
341-
data_vio_count_t get_data_vio_pool_maximum_discards(struct data_vio_pool *pool);
342-
int __must_check set_data_vio_pool_discard_limit(struct data_vio_pool *pool,
343-
data_vio_count_t limit);
344339
data_vio_count_t get_data_vio_pool_active_requests(struct data_vio_pool *pool);
345340
data_vio_count_t get_data_vio_pool_request_limit(struct data_vio_pool *pool);
346341
data_vio_count_t get_data_vio_pool_maximum_requests(struct data_vio_pool *pool);

0 commit comments

Comments
 (0)