Skip to content

Commit 27eb86e

Browse files
Florian Westphalummakynes
authored andcommitted
selftests: netfilter: add test case for recent mismatch bug
Without 'nft_set_pipapo: fix incorrect avx2 match of 5th field octet" this fails: TEST: reported issues Add two elements, flush, re-add 1s [ OK ] net,mac with reload 0s [ OK ] net,port,proto 3s [ OK ] avx2 false match 0s [FAIL] False match for fe80:dead:01fe:0a02:0b03:6007:8009:a001 Other tests do not detect the kernel bug as they only alter parts in the /64 netmask. Reviewed-by: Stefano Brivio <sbrivio@redhat.com> Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
1 parent e042ed9 commit 27eb86e

File tree

1 file changed

+38
-1
lines changed

1 file changed

+38
-1
lines changed

tools/testing/selftests/net/netfilter/nft_concat_range.sh

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ TYPES="net_port port_net net6_port port_proto net6_port_mac net6_port_mac_proto
2727
net6_port_net6_port net_port_mac_proto_net"
2828

2929
# Reported bugs, also described by TYPE_ variables below
30-
BUGS="flush_remove_add reload net_port_proto_match"
30+
BUGS="flush_remove_add reload net_port_proto_match avx2_mismatch"
3131

3232
# List of possible paths to pktgen script from kernel tree for performance tests
3333
PKTGEN_SCRIPT_PATHS="
@@ -387,6 +387,25 @@ race_repeat 0
387387
388388
perf_duration 0
389389
"
390+
391+
TYPE_avx2_mismatch="
392+
display avx2 false match
393+
type_spec inet_proto . ipv6_addr
394+
chain_spec meta l4proto . ip6 daddr
395+
dst proto addr6
396+
src
397+
start 1
398+
count 1
399+
src_delta 1
400+
tools ping
401+
proto icmp6
402+
403+
race_repeat 0
404+
405+
perf_duration 0
406+
"
407+
408+
390409
# Set template for all tests, types and rules are filled in depending on test
391410
set_template='
392411
flush ruleset
@@ -1629,6 +1648,24 @@ test_bug_net_port_proto_match() {
16291648
nft flush ruleset
16301649
}
16311650

1651+
test_bug_avx2_mismatch()
1652+
{
1653+
setup veth send_"${proto}" set || return ${ksft_skip}
1654+
1655+
local a1="fe80:dead:01ff:0a02:0b03:6007:8009:a001"
1656+
local a2="fe80:dead:01fe:0a02:0b03:6007:8009:a001"
1657+
1658+
nft "add element inet filter test { icmpv6 . $a1 }"
1659+
1660+
dst_addr6="$a2"
1661+
send_icmp6
1662+
1663+
if [ "$(count_packets)" -gt "0" ]; then
1664+
err "False match for $a2"
1665+
return 1
1666+
fi
1667+
}
1668+
16321669
test_reported_issues() {
16331670
eval test_bug_"${subtest}"
16341671
}

0 commit comments

Comments
 (0)