Skip to content

Commit 2765de9

Browse files
committed
Merge tag 'regulator-fix-v6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
Pull regulator fixes from Mark Brown: "A few driver specific fixes for incorrect device descriptions, plus a fix for a missing symbol export which causes build failures for some newly added drivers in other trees" * tag 'regulator-fix-v6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator: regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones regulator: bd71815: fix ramp values regulator: core: Fix modpost error "regulator_get_regmap" undefined regulator: tps6594-regulator: Fix the number of irqs for TPS65224 and TPS6594
2 parents e24638a + 0057222 commit 2765de9

File tree

4 files changed

+25
-23
lines changed

4 files changed

+25
-23
lines changed

drivers/regulator/axp20x-regulator.c

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@
140140

141141
#define AXP717_DCDC1_NUM_VOLTAGES 88
142142
#define AXP717_DCDC2_NUM_VOLTAGES 107
143-
#define AXP717_DCDC3_NUM_VOLTAGES 104
143+
#define AXP717_DCDC3_NUM_VOLTAGES 103
144144
#define AXP717_DCDC_V_OUT_MASK GENMASK(6, 0)
145145
#define AXP717_LDO_V_OUT_MASK GENMASK(4, 0)
146146

@@ -763,10 +763,15 @@ static const struct linear_range axp717_dcdc1_ranges[] = {
763763
REGULATOR_LINEAR_RANGE(1220000, 71, 87, 20000),
764764
};
765765

766+
/*
767+
* The manual says that the last voltage is 3.4V, encoded as 0b1101011 (107),
768+
* but every other method proves that this is wrong, so it's really 106 that
769+
* programs the final 3.4V.
770+
*/
766771
static const struct linear_range axp717_dcdc2_ranges[] = {
767772
REGULATOR_LINEAR_RANGE(500000, 0, 70, 10000),
768773
REGULATOR_LINEAR_RANGE(1220000, 71, 87, 20000),
769-
REGULATOR_LINEAR_RANGE(1600000, 88, 107, 100000),
774+
REGULATOR_LINEAR_RANGE(1600000, 88, 106, 100000),
770775
};
771776

772777
static const struct linear_range axp717_dcdc3_ranges[] = {
@@ -790,40 +795,40 @@ static const struct regulator_desc axp717_regulators[] = {
790795
AXP_DESC(AXP717, DCDC4, "dcdc4", "vin4", 1000, 3700, 100,
791796
AXP717_DCDC4_CONTROL, AXP717_DCDC_V_OUT_MASK,
792797
AXP717_DCDC_OUTPUT_CONTROL, BIT(3)),
793-
AXP_DESC(AXP717, ALDO1, "aldo1", "vin1", 500, 3500, 100,
798+
AXP_DESC(AXP717, ALDO1, "aldo1", "aldoin", 500, 3500, 100,
794799
AXP717_ALDO1_CONTROL, AXP717_LDO_V_OUT_MASK,
795800
AXP717_LDO0_OUTPUT_CONTROL, BIT(0)),
796-
AXP_DESC(AXP717, ALDO2, "aldo2", "vin1", 500, 3500, 100,
801+
AXP_DESC(AXP717, ALDO2, "aldo2", "aldoin", 500, 3500, 100,
797802
AXP717_ALDO2_CONTROL, AXP717_LDO_V_OUT_MASK,
798803
AXP717_LDO0_OUTPUT_CONTROL, BIT(1)),
799-
AXP_DESC(AXP717, ALDO3, "aldo3", "vin1", 500, 3500, 100,
804+
AXP_DESC(AXP717, ALDO3, "aldo3", "aldoin", 500, 3500, 100,
800805
AXP717_ALDO3_CONTROL, AXP717_LDO_V_OUT_MASK,
801806
AXP717_LDO0_OUTPUT_CONTROL, BIT(2)),
802-
AXP_DESC(AXP717, ALDO4, "aldo4", "vin1", 500, 3500, 100,
807+
AXP_DESC(AXP717, ALDO4, "aldo4", "aldoin", 500, 3500, 100,
803808
AXP717_ALDO4_CONTROL, AXP717_LDO_V_OUT_MASK,
804809
AXP717_LDO0_OUTPUT_CONTROL, BIT(3)),
805-
AXP_DESC(AXP717, BLDO1, "bldo1", "vin1", 500, 3500, 100,
810+
AXP_DESC(AXP717, BLDO1, "bldo1", "bldoin", 500, 3500, 100,
806811
AXP717_BLDO1_CONTROL, AXP717_LDO_V_OUT_MASK,
807812
AXP717_LDO0_OUTPUT_CONTROL, BIT(4)),
808-
AXP_DESC(AXP717, BLDO2, "bldo2", "vin1", 500, 3500, 100,
813+
AXP_DESC(AXP717, BLDO2, "bldo2", "bldoin", 500, 3500, 100,
809814
AXP717_BLDO2_CONTROL, AXP717_LDO_V_OUT_MASK,
810815
AXP717_LDO0_OUTPUT_CONTROL, BIT(5)),
811-
AXP_DESC(AXP717, BLDO3, "bldo3", "vin1", 500, 3500, 100,
816+
AXP_DESC(AXP717, BLDO3, "bldo3", "bldoin", 500, 3500, 100,
812817
AXP717_BLDO3_CONTROL, AXP717_LDO_V_OUT_MASK,
813818
AXP717_LDO0_OUTPUT_CONTROL, BIT(6)),
814-
AXP_DESC(AXP717, BLDO4, "bldo4", "vin1", 500, 3500, 100,
819+
AXP_DESC(AXP717, BLDO4, "bldo4", "bldoin", 500, 3500, 100,
815820
AXP717_BLDO4_CONTROL, AXP717_LDO_V_OUT_MASK,
816821
AXP717_LDO0_OUTPUT_CONTROL, BIT(7)),
817-
AXP_DESC(AXP717, CLDO1, "cldo1", "vin1", 500, 3500, 100,
822+
AXP_DESC(AXP717, CLDO1, "cldo1", "cldoin", 500, 3500, 100,
818823
AXP717_CLDO1_CONTROL, AXP717_LDO_V_OUT_MASK,
819824
AXP717_LDO1_OUTPUT_CONTROL, BIT(0)),
820-
AXP_DESC(AXP717, CLDO2, "cldo2", "vin1", 500, 3500, 100,
825+
AXP_DESC(AXP717, CLDO2, "cldo2", "cldoin", 500, 3500, 100,
821826
AXP717_CLDO2_CONTROL, AXP717_LDO_V_OUT_MASK,
822827
AXP717_LDO1_OUTPUT_CONTROL, BIT(1)),
823-
AXP_DESC(AXP717, CLDO3, "cldo3", "vin1", 500, 3500, 100,
828+
AXP_DESC(AXP717, CLDO3, "cldo3", "cldoin", 500, 3500, 100,
824829
AXP717_CLDO3_CONTROL, AXP717_LDO_V_OUT_MASK,
825830
AXP717_LDO1_OUTPUT_CONTROL, BIT(2)),
826-
AXP_DESC(AXP717, CLDO4, "cldo4", "vin1", 500, 3500, 100,
831+
AXP_DESC(AXP717, CLDO4, "cldo4", "cldoin", 500, 3500, 100,
827832
AXP717_CLDO4_CONTROL, AXP717_LDO_V_OUT_MASK,
828833
AXP717_LDO1_OUTPUT_CONTROL, BIT(3)),
829834
AXP_DESC(AXP717, CPUSLDO, "cpusldo", "vin1", 500, 1400, 50,

drivers/regulator/bd71815-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ static int buck12_set_hw_dvs_levels(struct device_node *np,
256256
* 10: 2.50mV/usec 10mV 4uS
257257
* 11: 1.25mV/usec 10mV 8uS
258258
*/
259-
static const unsigned int bd7181x_ramp_table[] = { 1250, 2500, 5000, 10000 };
259+
static const unsigned int bd7181x_ramp_table[] = { 10000, 5000, 2500, 1250 };
260260

261261
static int bd7181x_led_set_current_limit(struct regulator_dev *rdev,
262262
int min_uA, int max_uA)

drivers/regulator/core.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3347,6 +3347,7 @@ struct regmap *regulator_get_regmap(struct regulator *regulator)
33473347

33483348
return map ? map : ERR_PTR(-EOPNOTSUPP);
33493349
}
3350+
EXPORT_SYMBOL_GPL(regulator_get_regmap);
33503351

33513352
/**
33523353
* regulator_get_hardware_vsel_register - get the HW voltage selector register

drivers/regulator/tps6594-regulator.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -653,18 +653,14 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
653653
}
654654
}
655655

656-
if (tps->chip_id == LP8764) {
657-
nr_buck = ARRAY_SIZE(buck_regs);
658-
nr_ldo = 0;
659-
nr_types = REGS_INT_NB;
660-
} else if (tps->chip_id == TPS65224) {
656+
if (tps->chip_id == TPS65224) {
661657
nr_buck = ARRAY_SIZE(tps65224_buck_regs);
662658
nr_ldo = ARRAY_SIZE(tps65224_ldo_regs);
663-
nr_types = REGS_INT_NB;
659+
nr_types = TPS65224_REGS_INT_NB;
664660
} else {
665661
nr_buck = ARRAY_SIZE(buck_regs);
666-
nr_ldo = ARRAY_SIZE(tps6594_ldo_regs);
667-
nr_types = TPS65224_REGS_INT_NB;
662+
nr_ldo = (tps->chip_id == LP8764) ? 0 : ARRAY_SIZE(tps6594_ldo_regs);
663+
nr_types = REGS_INT_NB;
668664
}
669665

670666
reg_irq_nb = nr_types * (nr_buck + nr_ldo);

0 commit comments

Comments
 (0)