Skip to content

Commit 1b66124

Browse files
Bo-Cun Chenkuba-moo
authored andcommitted
net: ethernet: mtk_eth_soc: revise QDMA packet scheduler settings
The QDMA packet scheduler suffers from a performance issue. Fix this by picking up changes from MediaTek's SDK which change to use Token Bucket instead of Leaky Bucket and fix the SPEED_1000 configuration. Fixes: 160d3a9 ("net: ethernet: mtk_eth_soc: introduce MTK_NETSYS_V2 support") Signed-off-by: Bo-Cun Chen <bc-bocun.chen@mediatek.com> Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: https://patch.msgid.link/18040f60f9e2f5855036b75b28c4332a2d2ebdd8.1744764277.git.daniel@makrotopia.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 6b02eb3 commit 1b66124

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/ethernet/mediatek/mtk_eth_soc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -762,8 +762,8 @@ static void mtk_set_queue_speed(struct mtk_eth *eth, unsigned int idx,
762762
break;
763763
case SPEED_1000:
764764
val |= MTK_QTX_SCH_MAX_RATE_EN |
765-
FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 10) |
766-
FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 5) |
765+
FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 1) |
766+
FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 6) |
767767
FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 10);
768768
break;
769769
default:
@@ -3320,7 +3320,7 @@ static int mtk_start_dma(struct mtk_eth *eth)
33203320
if (mtk_is_netsys_v2_or_greater(eth))
33213321
val |= MTK_MUTLI_CNT | MTK_RESV_BUF |
33223322
MTK_WCOMP_EN | MTK_DMAD_WR_WDONE |
3323-
MTK_CHK_DDONE_EN | MTK_LEAKY_BUCKET_EN;
3323+
MTK_CHK_DDONE_EN;
33243324
else
33253325
val |= MTK_RX_BT_32DWORDS;
33263326
mtk_w32(eth, val, reg_map->qdma.glo_cfg);

0 commit comments

Comments
 (0)