Skip to content

Commit 16c6cac

Browse files
Dan Carpenterbroonie
authored andcommitted
spi: sg2044-nor: fix signedness bug in sg2044_spifmc_write()
The "ret" variable needs to be signed for the error handling to work. It should be type int, since it only holds zero and negative error codes. Fixes: de16c32 ("spi: sophgo: add SG2044 SPI NOR controller driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> Link: https://patch.msgid.link/4e16e1bf-e5fb-4771-bc92-c5cba9aac473@stanley.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 336a41c commit 16c6cac

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/spi/spi-sg2044-nor.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ static ssize_t sg2044_spifmc_write(struct sg2044_spifmc *spifmc,
216216
size_t xfer_size;
217217
const u8 *dout = op->data.buf.out;
218218
int i, offset;
219-
size_t ret;
219+
int ret;
220220
u32 reg;
221221

222222
reg = sg2044_spifmc_init_reg(spifmc);

0 commit comments

Comments
 (0)