Skip to content

Commit 14f2e4a

Browse files
Christoph HellwigChandan Babu R
authored andcommitted
xfs: move the xfs_attr_sf_lookup tracepoint
trace_xfs_attr_sf_lookup is currently only called by xfs_attr_shortform_lookup, which despit it's name is a simple helper for xfs_attr_shortform_addname, which has it's own tracing. Move the callsite to xfs_attr_shortform_getvalue, which is the closest thing to a high level lookup we have for the Linux xattr API. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
1 parent 45c76a2 commit 14f2e4a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

fs/xfs/libxfs/xfs_attr_leaf.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -876,8 +876,6 @@ xfs_attr_shortform_lookup(
876876
struct xfs_attr_sf_entry *sfe;
877877
int i;
878878

879-
trace_xfs_attr_sf_lookup(args);
880-
881879
ASSERT(ifp->if_format == XFS_DINODE_FMT_LOCAL);
882880
sfe = &sf->list[0];
883881
for (i = 0; i < sf->hdr.count;
@@ -905,6 +903,9 @@ xfs_attr_shortform_getvalue(
905903
int i;
906904

907905
ASSERT(args->dp->i_af.if_format == XFS_DINODE_FMT_LOCAL);
906+
907+
trace_xfs_attr_sf_lookup(args);
908+
908909
sfe = &sf->list[0];
909910
for (i = 0; i < sf->hdr.count;
910911
sfe = xfs_attr_sf_nextentry(sfe), i++) {

0 commit comments

Comments
 (0)