Skip to content

Commit 1154e43

Browse files
jailuthragregkh
authored andcommitted
usb: typec: tipd: Separate reset for TPS6598x
Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if TPS6598x is cold-reset during unconditionally on probe failures by sending "GAID" sequence. The probe can fail initially because USB0 remote-endpoint may not be probed yet, which defines the usb-role-switch property. Fixes: d49f908 ("usb: typec: tipd: add init and reset functions to tipd_data") Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/ Signed-off-by: Jai Luthra <j-luthra@ti.com> Reviewed-by: Roger Quadros <rogerq@kernel.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20240105-next-tps-fix-v1-1-158cabaec168@ti.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2dd23cc commit 1154e43

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

drivers/usb/typec/tipd/core.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1223,11 +1223,16 @@ static int cd321x_reset(struct tps6598x *tps)
12231223
return 0;
12241224
}
12251225

1226-
static int tps6598x_reset(struct tps6598x *tps)
1226+
static int tps25750_reset(struct tps6598x *tps)
12271227
{
12281228
return tps6598x_exec_cmd_tmo(tps, "GAID", 0, NULL, 0, NULL, 2000, 0);
12291229
}
12301230

1231+
static int tps6598x_reset(struct tps6598x *tps)
1232+
{
1233+
return 0;
1234+
}
1235+
12311236
static int
12321237
tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
12331238
{
@@ -1545,7 +1550,7 @@ static const struct tipd_data tps25750_data = {
15451550
.trace_status = trace_tps25750_status,
15461551
.apply_patch = tps25750_apply_patch,
15471552
.init = tps25750_init,
1548-
.reset = tps6598x_reset,
1553+
.reset = tps25750_reset,
15491554
};
15501555

15511556
static const struct of_device_id tps6598x_of_match[] = {

0 commit comments

Comments
 (0)