Skip to content

Commit 0dc83ad

Browse files
mszyprowbebarino
authored andcommitted
clk: samsung: Don't register clkdev lookup for the fixed rate clocks
Commit 4d11c62 ("clkdev: report over-sized strings when creating clkdev entries") revealed that clock lookup is registered for all fixed clocks. The mentioned commit added a check if the registered name is not too long. This fails for some clocks registered for Exynos542x SoCs family. This lookup is a left-over from early common clock framework days, not really needed nowadays, so remove it to avoid further issues. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Tested-by: Sam Protsenko <semen.protsenko@linaro.org> Link: https://lore.kernel.org/r/20240510065901.535124-1-m.szyprowski@samsung.com Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent ce68962 commit 0dc83ad

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

drivers/clk/samsung/clk.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ void __init samsung_clk_register_fixed_rate(struct samsung_clk_provider *ctx,
139139
unsigned int nr_clk)
140140
{
141141
struct clk_hw *clk_hw;
142-
unsigned int idx, ret;
142+
unsigned int idx;
143143

144144
for (idx = 0; idx < nr_clk; idx++, list++) {
145145
clk_hw = clk_hw_register_fixed_rate(ctx->dev, list->name,
@@ -151,15 +151,6 @@ void __init samsung_clk_register_fixed_rate(struct samsung_clk_provider *ctx,
151151
}
152152

153153
samsung_clk_add_lookup(ctx, clk_hw, list->id);
154-
155-
/*
156-
* Unconditionally add a clock lookup for the fixed rate clocks.
157-
* There are not many of these on any of Samsung platforms.
158-
*/
159-
ret = clk_hw_register_clkdev(clk_hw, list->name, NULL);
160-
if (ret)
161-
pr_err("%s: failed to register clock lookup for %s",
162-
__func__, list->name);
163154
}
164155
}
165156

0 commit comments

Comments
 (0)