Skip to content

Commit 095c8e6

Browse files
hvilleneuvedoosuperna9999
authored andcommitted
drm: panel: jd9365da: fix reset signal polarity in unprepare
commit a8972d5 ("drm: panel: jd9365da-h3: fix reset signal polarity") fixed reset signal polarity in jadard_dsi_probe() and jadard_prepare(). It was not done in jadard_unprepare() because of an incorrect assumption about reset line handling in power off mode. After looking into the datasheet, it now appears that before disabling regulators, the reset line is deasserted first, and if reset_before_power_off_vcioo is true, then the reset line is asserted. Fix reset polarity by inverting gpiod_set_value() second argument in in jadard_unprepare(). Fixes: 6b818c5 ("drm: panel: Add Jadard JD9365DA-H3 DSI panel") Fixes: 2b976ad ("drm/panel: jd9365da: Support for kd101ne3-40ti MIPI-DSI panel") Fixes: a8972d5 ("drm: panel: jd9365da-h3: fix reset signal polarity") Cc: stable@vger.kernel.org Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20250417195507.778731-1-hugo@hugovil.com Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20250417195507.778731-1-hugo@hugovil.com
1 parent 1017560 commit 095c8e6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,11 @@ static int jadard_unprepare(struct drm_panel *panel)
129129
{
130130
struct jadard *jadard = panel_to_jadard(panel);
131131

132-
gpiod_set_value(jadard->reset, 1);
132+
gpiod_set_value(jadard->reset, 0);
133133
msleep(120);
134134

135135
if (jadard->desc->reset_before_power_off_vcioo) {
136-
gpiod_set_value(jadard->reset, 0);
136+
gpiod_set_value(jadard->reset, 1);
137137

138138
usleep_range(1000, 2000);
139139
}

0 commit comments

Comments
 (0)