Skip to content

Commit 06ab64a

Browse files
Philipp Stannerairlied
authored andcommitted
drm: vmwgfx_surface.c: copy user-array safely
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie <airlied@redhat.com> Signed-off-by: Philipp Stanner <pstanner@redhat.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Zack Rusin <zackr@vmware.com> Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230920123612.16914-7-pstanner@redhat.com
1 parent f37d63e commit 06ab64a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/vmwgfx/vmwgfx_surface.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -777,9 +777,9 @@ int vmw_surface_define_ioctl(struct drm_device *dev, void *data,
777777
sizeof(metadata->mip_levels));
778778
metadata->num_sizes = num_sizes;
779779
metadata->sizes =
780-
memdup_user((struct drm_vmw_size __user *)(unsigned long)
780+
memdup_array_user((struct drm_vmw_size __user *)(unsigned long)
781781
req->size_addr,
782-
sizeof(*metadata->sizes) * metadata->num_sizes);
782+
metadata->num_sizes, sizeof(*metadata->sizes));
783783
if (IS_ERR(metadata->sizes)) {
784784
ret = PTR_ERR(metadata->sizes);
785785
goto out_no_sizes;

0 commit comments

Comments
 (0)