ApplicationProblem and ApplicationException stacktrace message null fixed and dependencies versions upgraded

Author: officiallysingh

README.md

@@ -49,7 +49,7 @@ all can be done with zero custom code but by specifying error details in `proper
 
 ## Installation
 
-> **Current version: 1.7** Refer to [Release notes](https://github.com/officiallysingh/spring-boot-problem-handler/releases/tag/1.7) while upgrading
+> **Current version: 1.8** Refer to [Release notes](https://github.com/officiallysingh/spring-boot-problem-handler/releases/tag/1.7) while upgrading
 
 Add the `spring-boot-problem-handler` jar to application dependencies. That is all it takes to get a default working 
 exception handling mechanism in a Spring boot application.
@@ -62,12 +62,12 @@ Maven
 <dependency>
     <groupId>io.github.officiallysingh</groupId>
     <artifactId>spring-boot-problem-handler</artifactId>
-    <version>1.7</version>
+    <version>1.8</version>
 </dependency>
 ```
 Gradle
 ```groovy
-implementation 'io.github.officiallysingh:spring-boot-problem-handler:1.7'
+implementation 'io.github.officiallysingh:spring-boot-problem-handler:1.8'
 ```
 
 It does all hard part, A lot of advices are out of box available which are autoconfigured as `ControllerAdvice`s 

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>io.github.officiallysingh</groupId>
     <artifactId>spring-boot-problem-handler</artifactId>
-    <version>1.7</version>
+    <version>1.8</version>
     <name>spring-boot-problem-handler</name>
     <description>Commons exception handler library</description>
     <url>https://github.com/officiallysingh/spring-boot-problem-handler</url>
@@ -32,13 +32,13 @@
 
     <properties>
         <java.version>21</java.version>
-        <spring-boot.version>3.2.0</spring-boot.version>
-        <spring-cloud.version>2023.0.0</spring-cloud.version>
+        <spring-boot.version>3.2.5</spring-boot.version>
+        <spring-cloud.version>2023.0.1</spring-cloud.version>
         <jakarta.servlet-api.version>6.0.0</jakarta.servlet-api.version>
         <jakarta.annotation-api.version>2.1.1</jakarta.annotation-api.version>
-        <swagger-request-validator-spring-webmvc.version>2.39.0</swagger-request-validator-spring-webmvc.version>
+        <swagger-request-validator-spring-webmvc.version>2.40.0</swagger-request-validator-spring-webmvc.version>
         <commons-collections4.version>4.4</commons-collections4.version>
-        <guava.version>32.1.3-jre</guava.version>
+        <guava.version>33.1.0-jre</guava.version>
         <failsafe.version>2.4.4</failsafe.version>
 
         <scm.connection>scm:git:git@github.com:officiallysingh/spring-boot-problem-handler.git</scm.connection>
@@ -49,7 +49,7 @@
         <maven-release-plugin.version>3.0.0-M1</maven-release-plugin.version>
         <maven-deploy-plugin.version>3.1.1</maven-deploy-plugin.version>
 
-        <fmt-maven-plugin.version>2.21.1</fmt-maven-plugin.version>
+        <fmt-maven-plugin.version>2.23</fmt-maven-plugin.version>
         <maven-checkstyle-plugin.version>3.3.0</maven-checkstyle-plugin.version>
 
 		<maven.compiler.source>${java.version}</maven.compiler.source>
@@ -165,11 +165,15 @@
                 <groupId>com.spotify.fmt</groupId>
                 <artifactId>fmt-maven-plugin</artifactId>
                 <version>${fmt-maven-plugin.version}</version>
+<!--                <configuration>-->
+<!--                    <skip>true</skip>-->
+<!--                </configuration>-->
                 <executions>
                     <execution>
                         <goals>
                             <goal>format</goal>
                         </goals>
+
                     </execution>
                 </executions>
             </plugin>

src/main/java/com/ksoot/problem/core/ApplicationException.java

@@ -3,7 +3,6 @@
 import jakarta.annotation.Nullable;
 import java.util.Map;
 import lombok.Getter;
-import org.apache.commons.lang3.StringUtils;
 import org.springframework.http.HttpStatus;
 import org.springframework.util.Assert;
 
@@ -22,14 +21,15 @@ public final class ApplicationException extends Exception implements ProblemSupp
   private final Problem problem;
 
   private ApplicationException(
+      final String message,
       final HttpStatus status,
       final Problem problem,
       final String errorKey,
       @Nullable final String defaultDetail,
       @Nullable final Object[] detailArgs,
       @Nullable final ThrowableProblem cause,
       @Nullable final Map<String, Object> parameters) {
-    super(StringUtils.isNotEmpty(defaultDetail) ? defaultDetail : defaultDetail, cause);
+    super(message, cause);
     this.status = status;
     this.errorKey = errorKey;
     this.problem = problem;
@@ -48,11 +48,26 @@ public static ApplicationException of(
       @Nullable final Map<String, Object> parameters) {
     Assert.hasText(errorKey, "'errorKey' must not be null or empty");
     return new ApplicationException(
-        status, null, errorKey, defaultDetail, detailArgs, cause, parameters);
+        ProblemUtils.toMessage(errorKey, defaultDetail, null, cause),
+        status,
+        null,
+        errorKey,
+        defaultDetail,
+        detailArgs,
+        cause,
+        parameters);
   }
 
   public static ApplicationException of(final HttpStatus status, final Problem problem) {
     Assert.notNull(problem, "'problem' must not be null");
-    return new ApplicationException(status, problem, null, null, null, null, null);
+    return new ApplicationException(
+        ProblemUtils.toMessage(null, null, problem, null),
+        status,
+        problem,
+        null,
+        null,
+        null,
+        null,
+        null);
   }
 }

src/main/java/com/ksoot/problem/core/ApplicationProblem.java

@@ -21,14 +21,15 @@ public final class ApplicationProblem extends RuntimeException implements Proble
   private final Problem problem;
 
   private ApplicationProblem(
+      final String message,
       final HttpStatus status,
       final Problem problem,
       final String errorKey,
       @Nullable final String defaultDetail,
       @Nullable final Object[] detailArgs,
       @Nullable final ThrowableProblem cause,
       @Nullable final Map<String, Object> parameters) {
-    super(defaultDetail, cause);
+    super(message, cause);
     Assert.notNull(status, "'status' must not be null");
     this.status = status;
     this.errorKey = errorKey;
@@ -48,16 +49,39 @@ public static ApplicationProblem of(
       @Nullable final Map<String, Object> parameters) {
     Assert.hasText(errorKey, "'errorKey' must not be null or empty");
     return new ApplicationProblem(
-        status, null, errorKey, defaultDetail, detailArgs, cause, parameters);
+        ProblemUtils.toMessage(errorKey, defaultDetail, null, cause),
+        status,
+        null,
+        errorKey,
+        defaultDetail,
+        detailArgs,
+        cause,
+        parameters);
   }
 
   public static ApplicationProblem of(final HttpStatus status, final String errorKey) {
     Assert.hasText(errorKey, "'errorKey' must not be null or empty");
-    return new ApplicationProblem(status, null, errorKey, null, null, null, null);
+    return new ApplicationProblem(
+        ProblemUtils.toMessage(errorKey, null, null, null),
+        status,
+        null,
+        errorKey,
+        null,
+        null,
+        null,
+        null);
   }
 
   public static ApplicationProblem of(final HttpStatus status, final Problem problem) {
     Assert.notNull(problem, "'problem' must not be null");
-    return new ApplicationProblem(status, problem, null, problem.getDetail(), null, null, null);
+    return new ApplicationProblem(
+        ProblemUtils.toMessage(null, null, problem, null),
+        status,
+        problem,
+        null,
+        problem.getDetail(),
+        null,
+        null,
+        null);
   }
 }

src/main/java/com/ksoot/problem/core/ProblemUtils.java

@@ -1,13 +1,16 @@
 package com.ksoot.problem.core;
 
 import static java.util.Arrays.asList;
+import static java.util.stream.Collectors.joining;
 import static org.springframework.core.annotation.AnnotatedElementUtils.findMergedAnnotation;
 
 import com.ksoot.problem.spring.config.ProblemBeanRegistry;
 import jakarta.annotation.Nullable;
 import java.text.CharacterIterator;
 import java.text.StringCharacterIterator;
+import java.util.Objects;
 import java.util.Optional;
+import java.util.stream.Stream;
 import lombok.experimental.UtilityClass;
 import org.apache.commons.lang3.exception.ExceptionUtils;
 import org.springframework.http.HttpStatus;
@@ -85,4 +88,20 @@ public static String getStackTrace(final Throwable exception) {
     }
     return escapedStacktrace.toString();
   }
+
+  public static String toMessage(
+      @Nullable final String errorKey,
+      @Nullable final String defaultDetail,
+      @Nullable final Problem problem,
+      @Nullable final Problem cause) {
+    final Stream<String> parts =
+        Stream.of(
+                errorKey,
+                defaultDetail,
+                Objects.nonNull(problem) ? Problem.toString(problem) : null,
+                Objects.nonNull(cause) ? Problem.toString(cause) : null)
+            .filter(Objects::nonNull);
+
+    return parts.collect(joining(", "));
+  }
 }

src/main/java/com/ksoot/problem/spring/advice/application/ApplicationMultiProblemAdviceTrait.java

@@ -37,33 +37,37 @@ default R handleMultiProblem(final MultiProblem exception, final T request) {
           exception.getErrors().stream()
               .map(
                   ex -> {
-                    if (ex instanceof Problem problem) {
-                      return problem;
-                    } else if (ex instanceof ProblemSupport problemSupport) {
-                      if (Objects.nonNull(problemSupport.getProblem())) {
-                        return problemSupport.getProblem();
-                      } else {
-                        String errorKey = problemSupport.getErrorKey();
-                        String detailCode = ProblemConstant.DETAIL_CODE_PREFIX + errorKey;
+                    switch (ex) {
+                      case Problem problem -> {
+                        return problem;
+                      }
+                      case ProblemSupport problemSupport -> {
+                        if (Objects.nonNull(problemSupport.getProblem())) {
+                          return problemSupport.getProblem();
+                        } else {
+                          String errorKey = problemSupport.getErrorKey();
+                          String detailCode = ProblemConstant.DETAIL_CODE_PREFIX + errorKey;
 
+                          return toProblem(
+                              (Throwable) ex,
+                              problemSupport.getStatus(),
+                              errorKey,
+                              Optional.ofNullable(problemSupport.getDefaultDetail())
+                                  .orElse(detailCode),
+                              problemSupport.getDetailArgs(),
+                              Optional.ofNullable(problemSupport.getParameters())
+                                  .orElse(Collections.emptyMap()));
+                        }
+                      }
+                      case Throwable throwable -> {
                         return toProblem(
-                            (Throwable) ex,
-                            problemSupport.getStatus(),
-                            errorKey,
-                            Optional.ofNullable(problemSupport.getDefaultDetail())
-                                .orElse(detailCode),
-                            problemSupport.getDetailArgs(),
-                            Optional.ofNullable(problemSupport.getParameters())
-                                .orElse(Collections.emptyMap()));
+                            throwable,
+                            GeneralErrorKey.INTERNAL_SERVER_ERROR,
+                            HttpStatus.INTERNAL_SERVER_ERROR);
                       }
-                    } else if (ex instanceof Throwable throwable) {
-                      return toProblem(
-                          throwable,
-                          GeneralErrorKey.INTERNAL_SERVER_ERROR,
-                          HttpStatus.INTERNAL_SERVER_ERROR);
-                    } else {
-                      throw new IllegalStateException(
-                          "MultiProblem contain illegal instance: " + ex);
+                      case null, default ->
+                          throw new IllegalStateException(
+                              "MultiProblem contain illegal instance: " + ex);
                     }
                   })
               .toList());