Revision/separate nonconvex flow classes #1220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new name reflects the fact that INVEST_NON_CONVEX_FLOWS is not a subset of the set that is now called FIXED_CAPACITY_NONCONVEX_FLOWS. Originally (before solph 0.5), this was implicit as investment and binary status could not be combined. Now, the name was misleading. As this only affects expert users, we do not consider this API breaking.
To avoid misunderstandings about shared functionality, this splits shared functions from NonConvexFlowBlock to a separate file and imports it to both, InvestNonConvexFlowBlock amd NonConvexFlowBlock. Until now, one inherited from the other but this is rather historical than a parent child relationship in the sense of object oriented programming.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid misunderstandings about shared functionality, this splits shared functions from
NonConvexFlowBlockto a separate file and imports it to both,InvestNonConvexFlowBlockandNonConvexFlowBlock. Until now, one inherited from the other but this is rather historical than a parent child relationship in the sense of object oriented programming.