Streamline investment periods #1183
Conversation
Having aggregation periods now, we should be more precise here. I decided against INVESTMENT_PERIOD, which was used talking about this kind of periods before, as the period can also be relevant for parametrised capacities (without investemnt), e.g. `Flow(nominal_calacity=[5, 8])` for a model with two CAPACITY_PERIODS.
p-snft
force-pushed
the
revision/steamline_investment_periods
branch
from
bca6cfe to
9e9a9bb
Compare
Note: It was never unit-tested.
Turns out, there has been no unit test.
It was actually untested.
Discounting and interest rate are removed from InvestmentFlowBlock,
these numbers would now go to `c_{invest,var}(p)`.
Naming points in time instead of all time steps should be more flexible. Result processing is not adjusted, yet.
processing.Results is currently broken.
* m.es.investment_times is now always set * use Results object for tests
The test "test_without_last_time_point" was actually a test of processing functionality. The test "test_numeric_index" cannot be placed in the same template anymore as overwrriting the index is no longer supported.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| timeindex = pd.Index( | ||
| np.append(np.array([0]), np.cumsum(timeincrement)) | ||
| ) |
Check warning
Code scanning / CodeQL
Unreachable code Warning
|
Hi, im from the flixopt framework. |
|
Hi, @FBumann, thanks for reaching out. This is indeed interesting, but as you see also by the time this refactoring takes, we won't have time to prepare a list of options with their pros and cons. If you like, you can drop in at our next developer meeting in Berlin (https://oemof.org/2025/07/10/2025-09-user-developer-meeting-in-berlin-save-the-date/), which shouldn't be too far from your location for a day trip. Otherwise, you can either share your ideas so that we comment on them or browse the notes of our past developer meetings. We have (sparsely) documented our discussions. |
|
Hi @p-snft, Kind regards |
# Conflicts: # src/oemof/solph/components/experimental/_sink_dsm.py # tests/test_scripts/test_solph/test_multi_period_model/test_multi_period_dispatch_model.py
PERIODStoCAPACITY_PERIODS(The former can be easily confused with aggregation periods.)EnergySystem.periods(list[DateRange]) by keywordinvestment_times(list[Timestamp]).