Skip to content

When retrying based on x-ratelimit-reset, take local time and server time into account #599

@gr2m

Description

@gr2m

I've seen the plugin handle the primary rate limit correctly, wait until the provided x-ratelimit-reset time, and then immediately hit the rate limit again. My guess is that local time and server time are out-of-sync. It's something we had to take into account for the timeouts of installation access tokens as well in https://github.com/octokit/auth-app.js.

Metadata

Metadata

Assignees

Labels

Status: Up for grabsIssues that are ready to be worked on by anyoneType: BugSomething isn't working as documented

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions