Rule: 'no-sample-code' with --fix mapped to remove it

[saberzero1]

closes #11

Checks for these:

this.registerInterval(window.setInterval(() => console.log('setInterval'), 5 * 60 * 1000));

this.registerDomEvent(document, 'click', (evt: MouseEvent) => {
	console.log('click', evt);
});

Also has a fixable flag, which means running ESLint with --fix will remove both snippets automatically.

[claremacrae]

I don’t know what the intended boundaries of #11 are - but just to note that I have seen PR feedback tell plugin authors to rename things like classes that come from the sample plugin too.

Perhaps that is a separate PR.

[saberzero1]

I don’t know what the intended boundaries of #11 are - but just to note that I have seen PR feedback tell plugin authors to rename things like classes that come from the sample plugin too.

Perhaps that is a separate PR.

Yeah, I wondered that too. When I asked Joethei on Discord, he indicated that the two snippets this rule targets are very frequent remarks in code reviews, and should therefore be addressed. I suspect that this rule will be expanded in the future as Joethei reports frequent sample code snippets to address.

[joethei]

There is a rule for the sample names already

[saberzero1]

There is a rule for the sample names already

Great.

Do you want me to add any other sample code checks to this PR?