Make Regex Pattern for matching emoji match signifiers anywhere in the line

[sytone]

Looking at the way the match happens on the task the reg ex epects the match to always be at the end of the line by having $ on the end. Is there a reason for this?

If we have say [📅📆🗓] ?(\d{4}-\d{2}-\d{2}) and not [📅📆🗓] ?(\d{4}-\d{2}-\d{2})$ then the date can be anywhere in the string. The replace should also still work in this case. I tested it out in the code with the following jest test and worked fine.

This had a modification to the Tasks object and removes the $ from the regex for due and done.

    public static readonly dueDateRegex = /[📅📆🗓] ?(\d{4}-\d{2}-\d{2})/u;
    public static readonly doneDateRegex = /✅ ?(\d{4}-\d{2}-\d{2})/u;

    it('parses a task from a line with value anywhere', () => {
        // Arrange
        const line = '- [x] this is a done task 🗓 2021-09-12 ✅ 2021-06-20 #something';
        const path = 'this/is a path/to a/file.md';
        const sectionStart = 1337;
        const sectionIndex = 1209;
        const precedingHeader = 'Eloquent Section';

        // Act
        const task = Task.fromLine({
            line,
            path,
            sectionStart,
            sectionIndex,
            precedingHeader,
        });

        // Assert
        expect(task).not.toBeNull();
        expect(task!.description).toEqual('this is a done task #something');
        expect(task!.status).toStrictEqual(Status.Done);
        expect(task!.dueDate).not.toBeNull();
        expect(
            task!.dueDate!.isSame(moment('2021-09-12', 'YYYY-MM-DD')),
        ).toStrictEqual(true);
        expect(task!.doneDate).not.toBeNull();
        expect(
            task!.doneDate!.isSame(moment('2021-06-20', 'YYYY-MM-DD')),
        ).toStrictEqual(true);
    });

[schemar]

The reason is to avoid false positives. Maybe someone uses an emoji and a date in the task's description. We wouldn't want to match that.

For that reason, when parsing a task, we keep matching (and removing) from the end of the line until we don't find any more matches.

Also: it would be much harder to serialize tasks if the date can be anywhere. The user would expect the date to stay in place when, for example, toggling a task's status. At the moment, we simply append all metadata after the description, which is very easy to do.

[sytone]

Makes sense, so the structure is {user content}{task meta data} for all the tasks where the meta data starts from the end and works backwards once all meta data entries are processed/found.

[claremacrae]

I changed the title of this from:
Regex Pattern for matching
to:
Make Regex Pattern for matching emoji allow signifiers anywhere in the line
so it's clear what it was proposing