Tasks should support multiple files with the same name

[yutaizhou]

Expected Behavior

I have the following project folder structure

- Projects/
    - work_project1/
        - _todo.md
    - work_project2/
        - _todo.md
    - work_todo.md

so work_todo.md queries into each of the work_projectx/ folders for tasks using the tasks plugin. For example, for work_project1/, it uses

# Project 1
```tasks
path includes work_project1

Current Behavior

The tasks themselves are being queried correctly, but the note source listed would only point to _todo.md from work_project1, regardless of the path I specify. Seems bizarre especially since the tasks themselves are being queried right, it's just the listed source that is wrong.

# Project 1
- [ ] Correct project 1 todo (_todo) # the _todo file here is referenced correctly

# Project 2
- [ ] Correct project 2 todo (_todo) # the _todo file here is referenced wrong

Steps to Reproduce

Context (Environment)

• Obsidian version: 0.12.5
• Tasks version:
• [ x] I have tried it with all other plugins disabled and the error still occurs

Possible Solution

[yutaizhou]

So the source note was referenced wrong for a work_project2 task. I just tried inserting the task into a file with a different name within work_project2, like this:

- Projects/
    - work_project1/
        - _todo.md
    - work_project2/
        - _todo.md
        - _todo2.md
    - work_todo.md

And now the note is being referenced correctly

# Project 1
- [ ] Correct project 1 todo (_todo) # the _todo file here is referenced correctly

# Project 2
- [ ] Correct project 2 todo (_todo2) # the _todo2 file here is referenced correctly

[yutaizhou]

I actually have many project folders within Projects/, all with similar subfolder structures using filenames like _todo, _meeting, _approach, etc. So the actual repo structure is more like

- Projects/
    - work_project1/
        - _todo.md
        - _other_files....
    - work_project2/
        - _todo.md
        - _other_files....
    - personal_project1/
        - same subfolder structure
    - more projects/
    - work_todo.md

For the correctly retrieved task from project 2, since its wrongly referenced note came from project 1, I decided to delete project 1's folder. This just resulted in the reference note being taken as _todo from another project. So there is some obvious name collision error happening here; like the query is ignoring the filepath when getting the reference file, yet retrieving the task itself correctly by paying attention to the content of the filepath.

Now of course I can get around this issue by making my project folders like

- Projects/
    - work_project1/
        - _todo_project1.md
        - _meeting_project1.md
    - work_project2/
        - _todo_project2.md
        - _meeting_project2.md

But I would much rather adhere to a more uniform structure

[schemar]

Hey there,

thank you for the long information. It is true that Tasks only supports one instance of a file name at the moment. It used to be the case for Obsidian, but apparently that restriction no longer applies. I just checked Obsidian and it links to the full path if there can be a collision.

I would need to update how Tasks links to files based on this and also show the full path in case a collision is possible. This is not a high priority right now and my time is very limited already. I would be happy to get the required changes proposed by someone else, though 😋

[yutaizhou]

Ah I see, no problem. Using a mixture of Tasks plugin and Text Expand plugin have served my case well, since the latter does not suffer from this problem. Thank you for the awesome plugin! Especially love the natural language filter.

[Taitava]

I have run into the same problem, and I think I might be able to check if I'm able to make a pull request to fix this. I'm not sure if I'll manage to do it, as I'm not familiar with this plugin's source code, but I can try.

Should an issue be created for this? Or can I just make a PR without an actual issue, only referring to this discussion?

[schemar]

That would be awesome @Taitava 🙌 Ideally, you create an issue first where you talk about your proposed changes. That way, I can support if needed before you waste any time.

[Taitava]

I've now forked this repo and set up a working environment. I've looked the code a bit and seems that I can find a solution. I'll create an issue when I've come up with proposed changes.

[claremacrae]

This is no longer an issue. The links to tasks work fine when there are tasks from different files with the same file name.

See rhe commit 3197550, for example.

Marking as released.