GlobalFilter development

[ilandikov]

Started from discussion about #1047

GlobalFilter (GF) current behaviour & discoveries as of 1.24.0

• GF may start without a # eg TODO
• as input in Tasks eg collection
  • number of instances of GF in task line impacts grouping, filtering & sorting-> to be explored
  • GF is treated as a case-sensitive substring
    • Is «substring» a bug? -> on collection - no, on rendering - BUG
    • Is «case-sensitive» a bug? -> BUG
• as output from Tasks eg rendering
  • In reading mode
    • removing only the first instance of GF in reading mode -> to be decided (very special case #task/subtask1 #task/subtask2)
    • if subtag present, it will still be there eg #task/subtag -> /subtag -> BUG
• Documentation
  • 'If you use a tag such as #task as the global filter, you cannot add sub-tags to that tag' - this is not the actual behaviour. You can add subtags but they will be cut in the first occurrence eg #task/subtag -> /subtag
• Settings
  • tagged -> substring-> BUG
  • written: removes the string, fact: removes the FIRST string -> BUG

Generic early proposal

• GF as a separate entity from the Settings
• GF behaves as a substring on collection
• as a word on rendering

Behaviour to be decided

• A task contains only the GF and no description
• #1234 numbers only tags are treated as tags by Tasks plugin but are not tags for Obsidian
• What to do if GF = #1234

Maybe for a major release

• GF is a WORD eg set of char until the next whitespace or EOL (Breaking the current behaviour where GF is substring)

Next steps

• Analyse GF behaviour VS filtering & grouping

[claremacrae]

Thanks @ilandikov 👍

Here is the note that we were experimenting with, to establish the behaviours above.

Sub Tags of Global Filter.md

Note: We were actually experimenting with Tasks 1.23.0 - my bad - I thought it was 1.24.0. But in any case, the global filter code did not change between the two.

[ilandikov]

I tried to add more test cases and group them in some order
Sub.Tags.of.Global.Filter.md

Also accidentally discovered what seems to be a bug: if the task tag is global filter + subtag, the whole thing is shown in the edit task modal

[claremacrae]

Ah yes, we need to finish going through and documenting the current behaviour together...
Not until the date searching is done, though.

[ilandikov]

Not quite sure what you mean here (!== disagreement), let's discuss rapidly on our next session =)

[claremacrae]

Not quite sure what you mean here (!== disagreement), let's discuss rapidly on our next session =)

😄 Found it - it's the last lines in your big post at the start here:

Next steps

• Analyse GF behaviour VS filtering & grouping

(we should add 'sorting' to that list too...)

[ilandikov]

thanks. I updated the discussion. So by searching you mean the searching of tasks with the global filter VS filter, group and sort functions.

[ilandikov]

The position of the GF seems to be another issue - it may only be at the beginning of the tasks. Is shall be easily fixable in Task.ts:

if (hashTagMatch !== null) {
            tags = hashTagMatch.filter((tag) => tag !== globalFilter).map((tag) => tag.trim());
}

map() shall be called before the filter(), because the hashTagMatch contains untrimmed matches.