Skip to content

Commit e65c232

Browse files
committed
refactor: . rename TaskLayout and QueryLayout method names
1 parent 57181b3 commit e65c232

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/Layout/QueryLayout.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export class QueryLayout {
1616
}
1717
}
1818

19-
public applyQueryLayoutOptions() {
19+
public getHiddenClasses() {
2020
const taskListHiddenClasses: string[] = [];
2121
const componentsToGenerateClassesOnly: [boolean, string][] = [
2222
// The following components are handled in QueryRenderer.ts and thus are not part of the same flow that

src/Layout/TaskLayout.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export class TaskLayout {
1515
this.taskLayoutOptions = new TaskLayoutOptions();
1616
}
1717
}
18-
public applyTaskLayoutOptions() {
18+
public generateHiddenClasses() {
1919
const taskListHiddenClasses: string[] = [];
2020
this.taskLayoutOptions.toggleableComponents.forEach((component) => {
2121
generateHiddenClassForTaskList(

src/Renderer/QueryRenderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,9 @@ class QueryRenderChild extends MarkdownRenderChild {
226226

227227
taskList.addClasses(['contains-task-list', 'plugin-tasks-query-result']);
228228
const taskLayout = new TaskLayout(this.query.taskLayoutOptions);
229-
taskList.addClasses(taskLayout.applyTaskLayoutOptions());
229+
taskList.addClasses(taskLayout.generateHiddenClasses());
230230
const queryLayout = new QueryLayout(this.query.queryLayoutOptions);
231-
taskList.addClasses(queryLayout.applyQueryLayoutOptions());
231+
taskList.addClasses(queryLayout.getHiddenClasses());
232232

233233
const groupingAttribute = this.getGroupingAttribute();
234234
if (groupingAttribute && groupingAttribute.length > 0) taskList.dataset.taskGroupBy = groupingAttribute;

tests/Layout/TaskLayout.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe('TaskLayout tests', () => {
1212
const taskLayout = new TaskLayout();
1313
const queryLayout = new QueryLayout();
1414

15-
const hiddenClasses = [...taskLayout.applyTaskLayoutOptions(), ...queryLayout.applyQueryLayoutOptions()];
15+
const hiddenClasses = [...taskLayout.generateHiddenClasses(), ...queryLayout.getHiddenClasses()];
1616
expect(hiddenClasses.join('\n')).toMatchInlineSnapshot('"tasks-layout-hide-urgency"');
1717
});
1818

@@ -30,7 +30,7 @@ describe('TaskLayout tests', () => {
3030
const taskLayout = new TaskLayout(taskLayoutOptions);
3131
const queryLayout = new QueryLayout(queryLayoutOptions);
3232

33-
const hiddenClasses = [...taskLayout.applyTaskLayoutOptions(), ...queryLayout.applyQueryLayoutOptions()];
33+
const hiddenClasses = [...taskLayout.generateHiddenClasses(), ...queryLayout.getHiddenClasses()];
3434
expect(hiddenClasses.join('\n')).toMatchInlineSnapshot(`
3535
"tasks-layout-hide-id
3636
tasks-layout-hide-blockedBy

0 commit comments

Comments
 (0)