chore: Improve usability and content of PR template (#993)

* chore: Add more type-of-change options in PRs

I find myself often making changes not currently listed in the PR template types,
so I've added them.

Also added the Conventional Commit prefixes, to save having to check)

* chore: Add whitespace in PR template for readability

* chore: Add checkboxes to agree to terms in PRs

* chore: Link to documentation & contributing guides

Author: claremacrae

.github/pull_request_template.md

@@ -1,32 +1,58 @@
 <!--- Provide a general summary of your changes in the Title above -->
 
 # Description
+
 <!--- Describe your changes in detail -->
 
 ## Motivation and Context
+
 <!--- Why is this change required? What problem does it solve? -->
 <!--- If it fixes an open issue, please link to the issue here. -->
 
 ## How has this been tested?
+
 <!--- Please describe in detail how you tested your changes. -->
 <!--- Include details of your testing environment, tests ran to see how -->
 <!--- your change affects other areas of the code, etc. -->
 
 ## Screenshots (if appropriate)
 
 ## Types of changes
+
 <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
-- [ ] Bug fix (non-breaking change which fixes an issue)
-- [ ] Refactor (non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
-- [ ] New feature (non-breaking change which adds functionality)
-- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+
+Changes visible to users:
+
+- [ ] **Bug fix** (prefix: `fix` - non-breaking change which fixes an issue)
+- [ ] **New feature** (prefix: `feat` - non-breaking change which adds functionality)
+- [ ] **Breaking change** (prefix: `feat!!` or `fix!!` - fix or feature that would cause existing functionality to not work as expected)
+- [ ] **Documentation** (prefix: `docs` - improvements to any documentation content)
+- [ ] **Sample vault** (prefix: `sample` - improvements to the sample vault)
+
+Internal changes:
+
+- [ ] **Refactor** (prefix: `refactor` - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
+- [ ] **Tests** (prefix: `test` - additions and improvements to unit tests and the smoke tests)
+- [ ] **Infrastructure** (prefix: `chore` - examples include GitHub Actions, issue templates)
 
 ## Checklist
+
 <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
 <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
+
 - [ ] My code follows the code style of this project and passes `yarn run lint`.
 - [ ] My change requires a change to the documentation.
-- [ ] I have updated the documentation accordingly.
-- [ ] My change has adequate Unit Test coverage.
+- [ ] I have [updated the documentation](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/CONTRIBUTING.md#updating-documentation) accordingly.
+- [ ] My change has adequate [Unit Test coverage](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/CONTRIBUTING.md#maintaining-the-tests).
+
+## Terms
+
+<!--
+By submitting this pull request, you must agree to follow our
+[contributing guide](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/CONTRIBUTING.md) and
+[Code of Conduct](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/CODE_OF_CONDUCT.md).
+Put an x in the boxes to confirm you agree.
+-->
 
-By creating a Pull Request you agree to our [Code of Conduct](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/CODE_OF_CONDUCT.md). For further guidance on contributing please see [contributing guide](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/CONTRIBUTING.md)
+- [ ] My contribution follow this project's [contributing guide](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/CONTRIBUTING.md)
+- [ ] I agree to follow this project's [Code of Conduct](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/CODE_OF_CONDUCT.md)