refactor: simplify Cache.indexFile() (#1017)

* refactor: Flip if-else

Automated refactoring, done by WebStorm

* refactor: Remove unused assignment

Automated refactoring, done by WebStorm

(GitHook disabled, so I can show the working with WebStorm)

* refactor: Convert let to const

Automated refactoring, done by WebStorm

* refactor: Make fileContent const, for clarity.

Manual refactoring.

* refactor: Remove empty else block

Manual refactoring

Author: claremacrae

src/Cache.ts

@@ -205,16 +205,14 @@ export class Cache {
             return task.path === file.path;
         });
 
-        let listItems = fileCache.listItems;
-        let fileContent = '';
+        const listItems = fileCache.listItems;
+        // When there is no list items cache, there are no tasks.
+        // Still continue to notify watchers of removal.
+
         let newTasks: Task[] = [];
-        if (listItems === undefined) {
-            // When there is no list items cache, there are no tasks.
-            // Still continue to notify watchers of removal.
-            listItems = [];
-        } else {
+        if (listItems !== undefined) {
             // Only read the file and process for tasks if there are list items.
-            fileContent = await this.vault.cachedRead(file);
+            const fileContent = await this.vault.cachedRead(file);
             newTasks = Cache.getTasksFromFileContent(
                 fileContent,
                 listItems,