fix: Recognise '1) ' as a numbered list item.

Fixes #3401

Author: claremacrae

src/Task/TaskRegularExpressions.ts

@@ -5,8 +5,8 @@ export class TaskRegularExpressions {
     // Matches indentation before a list marker (including > for potentially nested blockquotes or Obsidian callouts)
     public static readonly indentationRegex = /^([\s\t>]*)/;
 
-    // Matches - * and + list markers, or numbered list markers (eg 1.)
-    public static readonly listMarkerRegex = /([-*+]|[0-9]+\.)/;
+    // Matches - * and + list markers, or numbered list markers, for example 1. and 1)
+    public static readonly listMarkerRegex = /([-*+]|[0-9]+[.)])/;
 
     // Matches a checkbox and saves the status character inside
     public static readonly checkboxRegex = /\[(.)\]/u;

tests/Obsidian/Cache.test.ts

@@ -151,7 +151,7 @@ describe('cache', () => {
         expect(tasks.length).toEqual(2);
     });
 
-    it.failing('should read numbered list items with closing parenthesis', () => {
+    it('should read numbered list items with closing parenthesis', () => {
         // See https://github.com/obsidian-tasks-group/obsidian-tasks/issues/3401
         //      "Unexpected failure to create a list item from line" warning when parsing "1)" style numbered list
         const data = numbered_list_items_with_paren;
@@ -167,7 +167,13 @@ describe('cache', () => {
             "
         `);
 
-        expect(printRoots(tasks)).toMatchInlineSnapshot('""');
+        expect(printRoots(tasks)).toMatchInlineSnapshot(`
+            "1) [ ] #task Task 1 in 'numbered_list_items_with_paren' : Task
+                1) Sub-item 1 : ListItem
+            2) [ ] #task Task 2 in 'numbered_list_items_with_paren' : Task
+                1) Sub-item 2 : ListItem
+            "
+        `);
         expect(tasks.length).toEqual(2);
     });
 
@@ -846,7 +852,6 @@ describe('all mock files', () => {
             const files_without_tasks = [
                 'Test Data/docs_sample_for_explain_query_file_defaults.md',
                 'Test Data/non_tasks.md',
-                'Test Data/numbered_list_items_with_paren.md',
             ];
             if (files_without_tasks.includes(path)) {
                 expect(tasks.length).toEqual(0);

tests/Task/TaskRegularExpressions.test.ts

@@ -9,6 +9,9 @@ describe('List Markers', () => {
         '0.',
         '1.',
         '12345.',
+        '0)',
+        '1)',
+        '12345)',
     ])('should be a valid list marker: "%s"', (candidate: string) => {
         expect(TaskRegularExpressions.listMarkerRegex.exec(candidate)).not.toBeNull();
     });
@@ -18,9 +21,6 @@ describe('List Markers', () => {
         '%',
         '.',
         ')',
-        '0)',
-        '1)',
-        '12345)',
     ])('should NOT be a valid list marker: "%s"', (candidate: string) => {
         expect(TaskRegularExpressions.listMarkerRegex.exec(candidate)).toBeNull();
     });