refactor: . Merge if/else

Author: claremacrae

src/Commands/ToggleDone.ts

@@ -42,19 +42,16 @@ export const toggleDone = (checking: boolean, editor: Editor, view: MarkdownView
     const taskIsOnLastLine = !taskWasNotOnLastLine;
     if (replacementTextIsNonEmpty) {
         editor.setLine(lineNumber, insertion.text);
-    } else {
+    } else if (taskIsOnLastLine) {
         // https://github.com/obsidian-tasks-group/obsidian-tasks/issues/3342
-        // If insertion.text is empty, delete the line instead, so we don't leave a trailing end-of-line character around.
-        if (taskIsOnLastLine) {
-            // There is no end-of-line character on our line, which is the last line in the file.
-            // console.log(`Deleting line "${editor.getLine(lineNumber)}", because insertion.text is empty.`);
-            editor.setLine(lineNumber, insertion.text);
-        } else {
-            const from = { line: lineNumber, ch: 0 };
-            const to = { line: lineNumber + 1, ch: 0 };
-            // console.log(`Deleting line+EOL "${editor.getRange(from, to)}", because insertion.text is empty.`);
-            editor.replaceRange('', from, to);
-        }
+        // There is no end-of-line character on our line, which is the last line in the file.
+        // console.log(`Deleting line "${editor.getLine(lineNumber)}", because insertion.text is empty.`);
+        editor.setLine(lineNumber, insertion.text);
+    } else {
+        const from = { line: lineNumber, ch: 0 };
+        const to = { line: lineNumber + 1, ch: 0 };
+        // console.log(`Deleting line+EOL "${editor.getRange(from, to)}", because insertion.text is empty.`);
+        editor.replaceRange('', from, to);
     }
 
     /* Cursor positions are 0-based for both "line" and "ch" offsets.