Merge pull request #2600 from obsidian-tasks-group/urgency-ignores-invalid-dates

fix: Make the Urgency calculation ignore invalid dates

Author: claremacrae

docs/Advanced/Urgency.md

@@ -27,6 +27,8 @@ Tasks simply sums up urgency scores of different aspects of a task:
 
 As you can tell from the table below, **due dates have the strongest influence on urgency.**
 
+Note that any invalid date values, referring to non-existent dates, are ignored.
+
 The scores are as follows:
 
 <!-- placeholder to force blank line before included text --><!-- include: DocsSamplesForUrgency.test.UrgencyTable_urgency-html-table.approved.md -->

docs/Support and Help/Breaking Changes.md

@@ -43,5 +43,6 @@ These are all bug-fixes, improving the default behaviour, and recorded here for
   - [[Filters#Happens|happens]] date now ignores any invalid dates.
   - `sort by [date]` now puts invalid dates before valid dates, as action is required. See [[Sorting#How dates are sorted]].
   - `group by [date]` now puts `Invalid [date] date` as the first heading.
+  - The [[urgency]] calculation now ignores any invalid dates.
   - `task.due.category` and `task.due.fromNow` now handle invalid dates as different from future dates. See [[Task Properties#Values in TasksDate Properties|Values in TasksDate Properties]].
 - Code snippets used to change the look of the Edit and Postpone buttons must be changed, as explained in [[How to style buttons]], which gives several examples.

src/Urgency.ts

@@ -11,7 +11,7 @@ export class Urgency {
     public static calculate(task: Task): number {
         let urgency = 0.0;
 
-        if (task.dueDate !== null) {
+        if (task.dueDate !== null && task.dueDate.isValid()) {
             // Map a range of 21 days to the value 0.2 - 1.0
             const startOfToday = window.moment().startOf('day');
             const daysOverdue = Math.round(startOfToday.diff(task.dueDate) / Urgency.milliSecondsPerDay);
@@ -29,13 +29,13 @@ export class Urgency {
             urgency += dueMultiplier * Urgency.dueCoefficient;
         }
 
-        if (task.scheduledDate !== null) {
+        if (task.scheduledDate !== null && task.scheduledDate.isValid()) {
             if (window.moment().isSameOrAfter(task.scheduledDate)) {
                 urgency += 1 * Urgency.scheduledCoefficient;
             }
         }
 
-        if (task.startDate !== null) {
+        if (task.startDate !== null && task.startDate.isValid()) {
             if (window.moment().isBefore(task.startDate)) {
                 urgency += 1 * Urgency.startedCoefficient;
             }