Protect static String array contents from modification.

greenrobot-team · greenrobot-team · commit abbba7be4b49 · 2020-05-11T13:36:49.000+02:00
diff --git a/objectbox-java/src/main/java/io/objectbox/model/EntityFlags.java b/objectbox-java/src/main/java/io/objectbox/model/EntityFlags.java
@@ -28,7 +28,8 @@ private EntityFlags() { }
    */
   public static final int USE_NO_ARG_CONSTRUCTOR = 1;
 
-  public static final String[] names = { "USE_NO_ARG_CONSTRUCTOR", };
+  // Private to protect contents from getting modified.
+  private static final String[] names = { "USE_NO_ARG_CONSTRUCTOR", };
 
   public static String name(int e) { return names[e - USE_NO_ARG_CONSTRUCTOR]; }
 }
diff --git a/objectbox-java/src/main/java/io/objectbox/model/PropertyType.java b/objectbox-java/src/main/java/io/objectbox/model/PropertyType.java
@@ -69,7 +69,8 @@ private PropertyType() { }
   public static final short DateVector = 31;
   public static final short DateNanoVector = 32;
 
-  public static final String[] names = { "Unknown", "Bool", "Byte", "Short", "Char", "Int", "Long", "Float", "Double", "String", "Date", "Relation", "DateNano", "Reserved2", "Reserved3", "Reserved4", "Reserved5", "Reserved6", "Reserved7", "Reserved8", "Reserved9", "Reserved10", "BoolVector", "ByteVector", "ShortVector", "CharVector", "IntVector", "LongVector", "FloatVector", "DoubleVector", "StringVector", "DateVector", "DateNanoVector", };
+  // Private to protect contents from getting modified.
+  private static final String[] names = { "Unknown", "Bool", "Byte", "Short", "Char", "Int", "Long", "Float", "Double", "String", "Date", "Relation", "DateNano", "Reserved2", "Reserved3", "Reserved4", "Reserved5", "Reserved6", "Reserved7", "Reserved8", "Reserved9", "Reserved10", "BoolVector", "ByteVector", "ShortVector", "CharVector", "IntVector", "LongVector", "FloatVector", "DoubleVector", "StringVector", "DateVector", "DateNanoVector", };
 
   public static String name(int e) { return names[e]; }
 }
diff --git a/objectbox-java/src/main/java/io/objectbox/query/OrderFlags.java b/objectbox-java/src/main/java/io/objectbox/query/OrderFlags.java
@@ -46,7 +46,8 @@ private OrderFlags() { }
    */
   public static final int NULLS_ZERO = 16;
 
-  public static final String[] names = { "DESCENDING", "CASE_SENSITIVE", "", "UNSIGNED", "", "", "", "NULLS_LAST", "", "", "", "", "", "", "", "NULLS_ZERO", };
+  // Private to protect contents from getting modified.
+  private static final String[] names = { "DESCENDING", "CASE_SENSITIVE", "", "UNSIGNED", "", "", "", "NULLS_LAST", "", "", "", "", "", "", "", "NULLS_ZERO", };
 
   public static String name(int e) { return names[e - DESCENDING]; }
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ private EntityFlags() { }`
`28`	`28`	`*/`
`29`	`29`	`public static final int USE_NO_ARG_CONSTRUCTOR = 1;`
`30`	`30`
`31`		`- public static final String[] names = { "USE_NO_ARG_CONSTRUCTOR", };`
	`31`	`+ // Private to protect contents from getting modified.`
	`32`	`+ private static final String[] names = { "USE_NO_ARG_CONSTRUCTOR", };`
`32`	`33`
`33`	`34`	`public static String name(int e) { return names[e - USE_NO_ARG_CONSTRUCTOR]; }`
`34`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,8 @@ private PropertyType() { }`
`69`	`69`	`public static final short DateVector = 31;`
`70`	`70`	`public static final short DateNanoVector = 32;`
`71`	`71`
`72`		`- public static final String[] names = { "Unknown", "Bool", "Byte", "Short", "Char", "Int", "Long", "Float", "Double", "String", "Date", "Relation", "DateNano", "Reserved2", "Reserved3", "Reserved4", "Reserved5", "Reserved6", "Reserved7", "Reserved8", "Reserved9", "Reserved10", "BoolVector", "ByteVector", "ShortVector", "CharVector", "IntVector", "LongVector", "FloatVector", "DoubleVector", "StringVector", "DateVector", "DateNanoVector", };`
	`72`	`+ // Private to protect contents from getting modified.`
	`73`	`+ private static final String[] names = { "Unknown", "Bool", "Byte", "Short", "Char", "Int", "Long", "Float", "Double", "String", "Date", "Relation", "DateNano", "Reserved2", "Reserved3", "Reserved4", "Reserved5", "Reserved6", "Reserved7", "Reserved8", "Reserved9", "Reserved10", "BoolVector", "ByteVector", "ShortVector", "CharVector", "IntVector", "LongVector", "FloatVector", "DoubleVector", "StringVector", "DateVector", "DateNanoVector", };`
`73`	`74`
`74`	`75`	`public static String name(int e) { return names[e]; }`
`75`	`76`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,8 @@ private OrderFlags() { }`
`46`	`46`	`*/`
`47`	`47`	`public static final int NULLS_ZERO = 16;`
`48`	`48`
`49`		`- public static final String[] names = { "DESCENDING", "CASE_SENSITIVE", "", "UNSIGNED", "", "", "", "NULLS_LAST", "", "", "", "", "", "", "", "NULLS_ZERO", };`
	`49`	`+ // Private to protect contents from getting modified.`
	`50`	`+ private static final String[] names = { "DESCENDING", "CASE_SENSITIVE", "", "UNSIGNED", "", "", "", "NULLS_LAST", "", "", "", "", "", "", "", "NULLS_ZERO", };`
`50`	`51`
`51`	`52`	`public static String name(int e) { return names[e - DESCENDING]; }`
`52`	`53`	`}`