Skip to content

Commit 1cebcfd

Browse files
committed
Tests: make contains_stringObjectMap use only string values
1 parent 2f984c5 commit 1cebcfd

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

tests/objectbox-java-test/src/test/java/io/objectbox/query/FlexQueryTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package io.objectbox.query;
1818

19-
import org.junit.Ignore;
2019
import org.junit.Test;
2120

2221
import java.util.ArrayList;
@@ -123,7 +122,6 @@ private TestEntity createFlexMapEntity(String s, boolean b, long l, float f, dou
123122
return entity;
124123
}
125124

126-
@Ignore("Broken due to flex map query API changes, see objectbox#1099")
127125
@Test
128126
public void contains_stringObjectMap() {
129127
// Note: map keys and values can not be null, so no need to test. See FlexMapConverterTest.
@@ -148,8 +146,8 @@ public void contains_stringObjectMap() {
148146

149147
// containsKeyValue only matches if key and value is equal.
150148
assertContainsKeyValue("banana-string", "banana");
151-
assertContainsKeyValue("banana-long", -1L);
152-
// containsKeyValue only supports strings and integers.
149+
// containsKeyValue only supports strings for now (TODO: until objectbox#1099 functionality is added).
150+
// assertContainsKeyValue("banana-long", -1L);
153151

154152
// setParameters works with strings and integers.
155153
Query<TestEntity> setParamQuery = box.query(
@@ -162,10 +160,10 @@ public void contains_stringObjectMap() {
162160
assertEquals(1, setParamResults.size());
163161
assertTrue(setParamResults.get(0).getStringObjectMap().containsKey("banana-string"));
164162

165-
setParamQuery.setParameters("contains", "banana milk shake-long", Long.toString(1));
163+
setParamQuery.setParameters("contains", "banana milk shake-string", "banana milk shake");
166164
setParamResults = setParamQuery.find();
167165
assertEquals(1, setParamResults.size());
168-
assertTrue(setParamResults.get(0).getStringObjectMap().containsKey("banana milk shake-long"));
166+
assertTrue(setParamResults.get(0).getStringObjectMap().containsKey("banana milk shake-string"));
169167
}
170168

171169
private void assertContainsKey(String key) {

0 commit comments

Comments
 (0)