Update to ns-3.38 and minor memory leak fixes (#101)

* lte-related changes

* non lte-related changes

* Update ns-3 to commit 9a2fd5d

* Update to ns-3.38 RC 1

* Improve readability of UpdateUeSinrEstimate

* Clear maps in the PHY classes object destructors

* Add author, changes and rel notes MD files

* Update to ns-3.38

* Add required internet-apps to enabled modules in the CI

* Reset PHY ptrs only when the simulation actually ends

* enforce new clang-format based code style

* add missing includes in lte test files

* add missing includes in lte/model

Author: pagmatt

.clang-format

@@ -1,53 +1,29 @@
 ---
 Language: Cpp
-AccessModifierOffset: -2
-AlignAfterOpenBracket: Align
-AlignConsecutiveAssignments: false
-AlignConsecutiveDeclarations: false
-AlignEscapedNewlinesLeft: true
-AlignOperands: true
-AlignTrailingComments: false
-AllowAllParametersOfDeclarationOnNextLine: true
-AllowShortBlocksOnASingleLine: false
-AllowShortCaseLabelsOnASingleLine: false
-AllowShortFunctionsOnASingleLine: None
-AllowShortIfStatementsOnASingleLine: false
-AllowShortLoopsOnASingleLine: false
-AlwaysBreakAfterReturnType: AllDefinitions
-AlwaysBreakTemplateDeclarations: true
-BinPackArguments: true
-BinPackParameters: true
-BreakBeforeBinaryOperators: None
-BreakBeforeBraces: Custom
-BraceWrapping:
-  AfterClass: true
-  AfterControlStatement: true
-  AfterFunction: true
-  AfterNamespace: false
-  AfterStruct: true
-  IndentBraces: true
-  BeforeElse: true
-BreakBeforeTernaryOperators: true
-BreakConstructorInitializersBeforeComma: false
+BasedOnStyle: Microsoft
+
+AllowAllArgumentsOnNextLine: false
+AllowAllParametersOfDeclarationOnNextLine: false
+AlwaysBreakAfterReturnType: TopLevelDefinitions
+AlwaysBreakTemplateDeclarations: Yes
+BinPackArguments: false
+BinPackParameters: false
 ColumnLimit: 100
-ConstructorInitializerAllOnOneLineOrOnePerLine: true
-Cpp11BracedListStyle: true
-DerivePointerAlignment: false
-IndentCaseLabels: false
-IndentWidth: 2
-NamespaceIndentation: None
-PointerAlignment: Right
-ReflowComments: false
-SortIncludes: false
-SpaceAfterCStyleCast: true
-SpaceAfterTemplateKeyword: true
-SpaceBeforeAssignmentOperators: true
-SpaceBeforeParens: Always
-SpaceInEmptyParentheses: false
-SpacesInAngles:  false
-SpacesInCStyleCastParentheses: false
-SpacesInParentheses: false
-SpacesInSquareBrackets: false
-Standard: 'Cpp11'
-UseTab: Never
-...
+DeriveLineEnding: false
+IncludeBlocks: Regroup
+IncludeCategories:
+  - Regex: '^(<|")ns3/'
+    Priority: 2
+    SortPriority: 0
+  - Regex: "^<"
+    Priority: 3
+    SortPriority: 0
+  - Regex: ".*"
+    Priority: 1
+    SortPriority: 0
+KeepEmptyLinesAtTheStartOfBlocks: false
+PackConstructorInitializers: Never
+PointerAlignment: Left
+QualifierAlignment: Left
+SeparateDefinitionBlocks: Always
+Standard: "c++17"

.clang-tidy

@@ -0,0 +1,50 @@
+Checks: >
+  -*,
+  bugprone-argument-comment,
+  bugprone-bool-pointer-implicit-conversion,
+  bugprone-inaccurate-erase,
+  bugprone-move-forwarding-reference,
+  bugprone-redundant-branch-condition,
+  bugprone-string-constructor,
+  bugprone-string-integer-assignment,
+  bugprone-suspicious-memset-usage,
+  bugprone-suspicious-semicolon,
+  bugprone-suspicious-string-compare,
+  bugprone-terminating-continue,
+  bugprone-too-small-loop-variable,
+  bugprone-virtual-near-miss,
+  misc-redundant-expression,
+  misc-static-assert,
+  modernize-make-shared,
+  modernize-make-unique,
+  modernize-redundant-void-arg,
+  modernize-use-emplace,
+  modernize-use-equals-delete,
+  modernize-use-nullptr,
+  modernize-use-override,
+  performance-faster-string-find,
+  performance-for-range-copy,
+  performance-implicit-conversion-in-loop,
+  performance-inefficient-algorithm,
+  performance-inefficient-vector-operation,
+  performance-trivially-destructible,
+  readability-braces-around-statements,
+  readability-container-size-empty,
+  readability-duplicate-include,
+  readability-isolate-declaration,
+  readability-make-member-function-const,
+  readability-misleading-indentation,
+  readability-misplaced-array-index,
+  readability-redundant-control-flow,
+  readability-redundant-function-ptr-dereference,
+  readability-redundant-smartptr-get,
+  readability-redundant-string-cstr,
+  readability-simplify-subscript-expr,
+  readability-static-accessed-through-instance,
+  readability-static-definition-in-anonymous-namespace,
+  readability-string-compare,
+  readability-uppercase-literal-suffix,
+
+FormatStyle: "file"
+HeaderFilterRegex: ".*(ns|NS).*/(contrib|examples|src|scratch|utils)/*/.*h"
+UseColor: true

.github/workflows/main.yml

@@ -24,4 +24,4 @@ jobs:
 
     # Enable only the mmwave module to speedup the test
     - name: build and run the tests
-      run: ./ns3 configure --enable-examples --enable-tests --enable-modules=mmwave && ./ns3 build && ./test.py
+      run: ./ns3 configure --enable-examples --enable-tests --enable-modules=mmwave,internet-apps && ./ns3 build && ./test.py

.vscode/.gitignore

@@ -0,0 +1,5 @@
+*
+!.gitignore
+
+!launch.json
+!tasks.json

.vscode/launch.json

@@ -0,0 +1,113 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "(gdb) Launch from scratch",
+            "type": "cppdbg",
+            "request": "launch",
+            "program": "${workspaceFolder}/build/${relativeFileDirname}/ns3-dev-${fileBasenameNoExtension}-${input:buildType}",
+            "args": [],
+            "stopAtEntry": false,
+            "cwd": "${workspaceFolder}",
+            "preLaunchTask": "Build",
+            "environment": [
+                {
+                    "name": "LD_LIBRARY_PATH",
+                    "value": "${workspaceFolder}/build/lib/"
+                }
+            ],
+            "externalConsole": false,
+            "MIMode": "gdb",
+            "setupCommands": [
+                {
+                    "description": "Enable pretty-printing for gdb",
+                    "text": "-enable-pretty-printing",
+                    "ignoreFailures": true
+                }
+            ]
+        },
+        {
+            "name": "(lldb) Launch from scratch",
+            "type": "cppdbg",
+            "request": "launch",
+            "program": "${workspaceFolder}/build/${relativeFileDirname}/ns3-dev-${fileBasenameNoExtension}-${input:buildType}",
+            "args": [],
+            "stopAtEntry": false,
+            "cwd": "${workspaceFolder}",
+            "preLaunchTask": "Build",
+            "environment": [
+                {
+                    "name": "LD_LIBRARY_PATH",
+                    "value": "${workspaceFolder}/build/lib/"
+                }
+            ],
+            "externalConsole": false,
+            "MIMode": "lldb"
+        },
+        {
+            "name": "(gdb) Launch testrunner",
+            "type": "cppdbg",
+            "request": "launch",
+            "program": "${workspaceFolder}/build/utils/ns3-dev-test-runner-${input:buildType}",
+            "args": [
+                "--suite=${selectedText}"
+            ],
+            "stopAtEntry": false,
+            "cwd": "${workspaceFolder}",
+            "preLaunchTask": "Build",
+            "environment": [
+                {
+                    "name": "LD_LIBRARY_PATH",
+                    "value": "${workspaceFolder}/build/lib/"
+                }
+            ],
+            "externalConsole": false,
+            "MIMode": "gdb",
+            "setupCommands": [
+                {
+                    "description": "Enable pretty-printing for gdb",
+                    "text": "-enable-pretty-printing",
+                    "ignoreFailures": true
+                }
+            ]
+        },
+        {
+            "name": "(lldb) Launch testrunner",
+            "type": "cppdbg",
+            "request": "launch",
+            "program": "${workspaceFolder}/build/utils/ns3-dev-test-runner-${input:buildType}",
+            "args": [
+                "--suite=${selectedText}"
+            ],
+            "stopAtEntry": false,
+            "cwd": "${workspaceFolder}",
+            "preLaunchTask": "Build",
+            "environment": [
+                {
+                    "name": "LD_LIBRARY_PATH",
+                    "value": "${workspaceFolder}/build/lib/"
+                }
+            ],
+            "externalConsole": false,
+            "MIMode": "lldb"
+        }
+    ],
+    "inputs": [
+        {
+            "type": "pickString",
+            "id": "buildType",
+            "description": "What is the build option?",
+            "options": [
+                "debug",
+                "default",
+                "optimized",
+                "release",
+                "minsizerel"
+            ],
+            "default": "default"
+        }
+    ]
+}

.vscode/tasks.json

@@ -0,0 +1,25 @@
+{
+    // See https://go.microsoft.com/fwlink/?LinkId=733558
+    // for the documentation about the tasks.json format
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "Build",
+            "type": "shell",
+            "command": "./ns3",
+            "group": {
+                "kind": "build",
+                "isDefault": true
+            }
+        },
+        {
+            "label": "Run tests",
+            "type": "shell",
+            "command": "./test.py",
+            "group": {
+                "kind": "test",
+                "isDefault": true
+            }
+        }
+    ]
+}

AUTHORS

@@ -68,9 +68,11 @@ Ankit Deepak (adadeepak8@gmail.com)
 Christophe Delahaye (christophe.delahaye@orange.com)
 Sébastien Deronne (sebastien.deronne@gmail.com)
 Ameya Deshpande (ameyanrd@outlook.com)
+Zhiheng Dong (dzh2077@gmail.com)
 Christoph Döpmann (doepmanc@informatik.hu-berlin.de)
 Jordan Dorham (dorham1@llnl.gov)
 Craig Dowell (craigdo@ee.washington.edu)
+Matteo Drago (matteo.drago1994@gmail.com)
 Gilaras Drakeson (gilaras@gmail.com)
 Jared Dulmage (jared.dulmage@wpli.net)
 Mathias Ettinger (mettinger@toulouse.viveris.com)
@@ -109,6 +111,7 @@ Frank Helbert (frank@ime.usp.br)
 Tom Henderson (tomhend@u.washington.edu)
 Christopher Hepner (hepner@hs-ulm.de)
 Budiarto Herman (budiarto.herman@magister.fi)
+Heun (git-gmb.hpmta@simplelogin.com)
 Tom Hewer (tomhewer@mac.com)
 Kristian A. Hiorth (kristahi@ifi.uio.no)
 Hrishikesh Hiraskar (hrishihirakar@gmail.com)
@@ -137,6 +140,7 @@ Ouassim Karrakchou (okarr102@uottawa.ca)
 Tanmay Kathpalia (tanmay.kathpalia@landisgyr.com)
 Konstantinos Katsaros (dinos.katsaros@gmail.com)
 Bhaskar Kataria (www.bhaskar.com7@gmail.com)
+Nils Kattenbeck (nils.kattenbeck@rwth-aachen.de)
 Morteza Kheirkhah (m.kheirkhah@sussex.ac.uk)
 Jörg Christian Kirchhof (christian.kirchhof@rwth-aachen.de)
 Ohad Klausner
@@ -187,6 +191,7 @@ Faker Moatamri (faker.moatamri@inria.fr)
 Edvin Močibob (edvin.mocibob@gmail.com)
 Amir Modarresi (amodarresi@ittc.ku.edu)
 Akash Mondal (a98mondal@gmail.com)
+Lars Moons (lars.moons@student.uantwerpen.be)
 Mike Moreton (mjvm_ns@hotmail.com)
 Michele Muccio (michelemuccio@virgilio.it)
 Esteban Municio (esteban.municio@urjc.es)
@@ -205,15 +210,16 @@ Michael Nowatkowski (nowatkom@gmail.com)
 Anh Nguyen (annguyen@ittc.ku.edu)
 Duy Nguyen (duy@soe.ucsc.edu)
 Alfonso Oliveira (af.oliveira.16@gmail.com)
+Wouter Overmeire (lodagro@gmail.com)
 Luis Pacheco (luisbelem@gmail.com)
+Matteo Pagin (mattpagg@gmail.com)
 Jendaipou Palmei (jendaipoupalmei@gmail.com)
-Lluís Parcerisa (parcerisa@gmail.com)
 Parth Pandya (parthpandyappp@gmail.com)
+Lluís Parcerisa (parcerisa@gmail.com)
 Mingyu Park (darkpmg@naver.com)
-Jendaipou Palmei (jendaipoupalmei@gmail.com)
-Parth Pandya (parthpandyappp@gmail.com)
 Harsh Patel (thadodaharsh10@gmail.com)
 Natale Patriciello (natale.patriciello@gmail.com)
+Pavinberg (pavin0702@gmail.com)
 Tommaso Pecorella (tommaso.pecorella@unifi.it)
 Guangyu Pei (guangyu.pei@boeing.com)
 Josh Pelkey (jpelkey@gatech.edu)
@@ -290,9 +296,11 @@ Rohit P. Tahiliani (tahiliar@tcd.ie)
 Dave Taht (dave.taht@bufferbloat.net)
 Marcos Talau (talau@users.sourceforge.net)
 Adrian S. W. Tam (adrian.sw.tam@gmail.com)
+Bill Tao (toyjet8@gmail.com)
 Cristiano Tapparello (cristiano.tapparello@rochester.edu)
 Hajime Tazaki (tazaki@sfc.wide.ad.jp)
 Wilson Thong (wilsonwk@ee.cityu.edu.hk)
+Lars Toenning (dev@ltoenning.de)
 Omer Topal (omer.topal@airties.com)
 Mauro Tortonesi (mauro.tortonesi@unife.it)
 Quincy Tse (quincy.tse@gmail.com)