Remove duplicate toUpperCase() calls

nyurik · web-flow · commit 85053db81036 · 2018-04-29T01:56:07.000+03:00
diff --git a/java/com/google/openlocationcode/OpenLocationCode.java b/java/com/google/openlocationcode/OpenLocationCode.java
@@ -153,11 +153,12 @@ public double getEastLongitude() {
    * @constructor
   */
   public OpenLocationCode(String code) throws IllegalArgumentException {
-    if (!isValidCode(code.toUpperCase())) {
+    String newCode = code.toUpperCase();
+    if (!isValidCode(newCode)) {
       throw new IllegalArgumentException(
           "The provided code '" + code + "' is not a valid Open Location Code.");
     }
-    this.code = code.toUpperCase();
+    this.code = newCode;
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -153,11 +153,12 @@ public double getEastLongitude() {`
`153`	`153`	`* @constructor`
`154`	`154`	`*/`
`155`	`155`	`public OpenLocationCode(String code) throws IllegalArgumentException {`
`156`		`- if (!isValidCode(code.toUpperCase())) {`
	`156`	`+ String newCode = code.toUpperCase();`
	`157`	`+ if (!isValidCode(newCode)) {`
`157`	`158`	`throw new IllegalArgumentException(`
`158`	`159`	`"The provided code '" + code + "' is not a valid Open Location Code.");`
`159`	`160`	`}`
`160`		`- this.code = code.toUpperCase();`
	`161`	`+ this.code = newCode;`
`161`	`162`	`}`
`162`	`163`
`163`	`164`	`/**`