Skip to content

Commit 71377c1

Browse files
committed
Merge branch 'release/1.6.10' into v1
2 parents 6a0f96d + 963e81e commit 71377c1

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# ImageOptimize Changelog
22

3+
## 1.6.10 - 2020.02.11
4+
### Changed
5+
* Normalize the file format to lowercase before transforming
6+
37
## 1.6.9 - 2020.02.06
48
### Changed
59
* Properly documented how the data in the `imageTransformTypeSettings` config is stored

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nystudio107/craft-imageoptimize",
33
"description": "Automatically create & optimize responsive image transforms, using either native Craft transforms or a service like Imgix, with zero template changes.",
44
"type": "craft-plugin",
5-
"version": "1.6.9",
5+
"version": "1.6.10",
66
"keywords": [
77
"craft",
88
"cms",

docs/docs/.vuepress/config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module.exports = {
22
title: 'Image Optimize Documentation',
33
description: 'Documentation for the Image Optimize plugin',
44
base: '/docs/image-optimize/',
5-
dest: '~/webdev/sites/nystudio107/web/docs/image-optimize',
5+
dest: '../../../sites/nystudio107/web/docs/image-optimize',
66
themeConfig: {
77
displayAllHeaders: true,
88
sidebar: [

src/services/Optimize.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ public function handleGetAssetUrlEvent(GetAssetUrlEvent $event)
160160
// For backwards compatibility
161161
if ($transform === null && ImageOptimize::$plugin->transformMethod instanceof ThumborImageTransform) {
162162
$transform = new AssetTransform([
163-
'height' => $asset->height,
164163
'width' => $asset->width,
165164
'interlace' => 'line',
166165
]);
@@ -179,6 +178,8 @@ public function handleGetAssetUrlEvent(GetAssetUrlEvent $event)
179178
if ($finalFormat === 'svg') {
180179
return null;
181180
}
181+
// Normalize the extension to lowercase, for some transform methods that require this
182+
$transform['format'] = strtolower($finalFormat);
182183
// Generate an image transform url
183184
$url = ImageOptimize::$plugin->transformMethod->getTransformUrl(
184185
$asset,
@@ -206,6 +207,7 @@ public function handleGetAssetThumbUrlEvent(GetAssetThumbUrlEvent $event)
206207
if (ImageHelper::canManipulateAsImage($asset->getExtension())) {
207208
$transform = new AssetTransform([
208209
'width' => $event->width,
210+
'height' => $event->height,
209211
'interlace' => 'line',
210212
]);
211213
/** @var ImageTransform $transformMethod */
@@ -215,6 +217,8 @@ public function handleGetAssetThumbUrlEvent(GetAssetThumbUrlEvent $event)
215217
if ($finalFormat === 'svg') {
216218
return null;
217219
}
220+
// Normalize the extension to lowercase, for some transform methods that require this
221+
$transform['format'] = strtolower($finalFormat);
218222
// Generate an image transform url
219223
if ($transformMethod->hasProperty('generateTransformsBeforePageLoad')) {
220224
$transformMethod->generateTransformsBeforePageLoad = $event->generate;

0 commit comments

Comments
 (0)